mirror of
https://github.com/OpenHands/OpenHands.git
synced 2026-10-07 15:58:03 +08:00
f6ea202d56c58e2a34c5d9f183fe96f2b4ea9e4c
7692
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
 Engel Nystandopenhands
|
f6ea202d56 |
chore: align package version with RC (#1303)
Keep package metadata in sync with config/defaults.json so npm scripts and mock E2E logs report the current agent-canvas RC version. Co-authored-by: openhands <openhands@all-hands.dev> |
||
|
Engel Nystandopenhands
|
39c816d38d |
fix: stabilize snapshot consent handling (#1304)
* fix: stabilize snapshot consent handling Seed the legacy analytics-consent key in snapshot tests so the server-backed analytics dialog closes before page interactions, and make snapshot reports distinguish visual diffs/new snapshots from actual workflow failures. * fix: only seed analytics consent for snapshots --------- Co-authored-by: openhands <openhands@all-hands.dev> |
||
|
Hiep Le
|
66394db18a | fix: translate English-copied keys and guard against untranslated values (#1305) | ||
|
Hiep Le
|
719e43c700 | feat: auto-select newly added workspace in workspace picker (#1307) | ||
|
Hiep Le
|
44dadb7ee2 | fix: route hardcoded UI strings through i18n (#1306) | ||
|
Tim O'Farrellandopenhands
|
bee6cee418 |
fix: set bundled skill source to real filesystem path (#1310)
* fix: set bundled skill source to real filesystem path
Bundled public skills were sent to the Python agent-server with
`source: "public"`, which the SDK uses as the skill's `location` in
SkillKnowledge. Any skill whose SKILL.md references bundled resources
(scripts/, references/) is therefore unable to resolve those files —
the agent sees 'Skill location: public' instead of an actual path.
Fix: compute the absolute path to the skills directory inside the
`@openhands/extensions` node_modules package at Vite build/serve time
and inject it as `__EXTENSIONS_SKILLS_DIR__` via Vite's `define`.
`buildBundledSkills()` now sets `source` to:
`${__EXTENSIONS_SKILLS_DIR__}/${name}/SKILL.md`
Library builds receive an empty string so consumers are not bound to
this machine's node_modules path; the adapter falls back to 'public'
when the value is falsy.
Co-authored-by: openhands <openhands@all-hands.dev>
* fix: declare __EXTENSIONS_SKILLS_DIR__ global for TypeScript
Add missing 'declare const __EXTENSIONS_SKILLS_DIR__: string' to
src/react-app-env.d.ts so tsc can resolve the Vite-injected constant
used in buildBundledSkills().
Co-authored-by: openhands <openhands@all-hands.dev>
* test: assert skill source is absolute path ending in /<name>/SKILL.md
Replace the loose 'typeof === string' / toBeTruthy checks with two specific
assertions that directly verify the intent of buildBundledSkills():
- source starts with '/' (absolute path the agent-server can resolve)
- source ends with '/<name>/SKILL.md' (points to the right file)
Co-authored-by: openhands <openhands@all-hands.dev>
---------
Co-authored-by: openhands <openhands@all-hands.dev>
|
||
|
aivong-openhands
|
5076bb3517 |
APP-2306: Add VITE_POSTHOG_CLIENT_KEY to Docker build (#1302)
* Add VITE_POSTHOG_CLIENT_KEY to Docker build Bake the PostHog client key into the frontend bundle at build time by accepting a VITE_POSTHOG_CLIENT_KEY build arg in the Dockerfile and passing it from the Docker workflow via the POSTHOG_CLIENT_KEY repo variable. The key is a public, client-side key (not a secret), following the same pattern as VITE_APP_ENV. Closes APP-2306 * Select staging/prod PostHog key by release tag Mirror the VITE_APP_ENV logic for VITE_POSTHOG_CLIENT_KEY: tagged v* releases bake the prod key, all other builds (PR/main/local) use staging. Both keys are public client-side keys (not secrets) sourced from the POSTHOG_CLIENT_KEY_PROD / POSTHOG_CLIENT_KEY_STAGING repo variables. * Rename PostHog repo vars to POSTHOG_STAGING_KEY / POSTHOG_PROD_KEY |
||
|
Tim O'Farrellandopenhands
|
994912fbe7 |
bump automation to 1.0.0a7 (#1298)
* bump automation to 1.0.0a7 and add automationSdk==agentServer version test - Update versions.automation: 1.0.0a6 → 1.0.0a7 (latest on PyPI) - Update versions.automationSdk: 1.22.1 → 1.27.0 openhands-automation==1.0.0a7 depends on openhands-sdk==1.27.0, which now matches versions.agentServer (1.27.0) - Add 'versions.automationSdk matches versions.agentServer' test in __tests__/scripts/check-sdk-version-sync.test.ts so any future bump that forgets to keep both fields in sync fails CI immediately - Add config/defaults.json to sdk-version-sync.yml path triggers so the PyPI metadata check also fires when the config file is changed Co-authored-by: openhands <openhands@all-hands.dev> * remove automationSdk==agentServer static test The sdk-version-sync workflow already covers the meaningful invariant (automationSdk matches what the released openhands-automation on PyPI actually depends on). The static test enforced automationSdk===agentServer at all times, but the script explicitly allows automationSdk to lag agentServer while a compatible automation release is pending — making the test both unnecessary and incorrect. Co-authored-by: openhands <openhands@all-hands.dev> --------- Co-authored-by: openhands <openhands@all-hands.dev> |
||
|
|
4ec694e86b |
Add workspace mode for local conversations (#1293)
* Add workspace mode for local conversations Selected local workspaces now default to direct repo/folder mode by passing workspaceMode=local_repo through the home launcher and conversation creation stack. The agent-server payload can now send worktree=false, so plain folders do not request git worktree setup by default. Conversations started without a selected workspace continue to request worktree=true. Adds a pill-style workspace mode selector beside the selected workspace preview with current backend labels limited to Local Repo and Cloud Repo plus the New Worktree option. Stores workspace_mode in client metadata so the selected mode can be preserved alongside selected_workspace. Coverage added for adapter payload defaults, service-level selected-workspace behavior, home launcher mode selection, and updated comments around worktree-mode grouping. Verified with focused vitest, typecheck, prettier check, and production build. * Localize workspace mode selector labels via i18n Replace the hardcoded "Local Repo" / "Cloud Repo" / "New Worktree" strings with COMMON$WORKSPACE_MODE_* translation keys (all 15 supported languages). getWorkspaceModeLabel becomes getWorkspaceModeI18nKey, returning an I18nKey that the selector translates with useTranslation, matching the getTaskStatusI18nKey convention. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix: failing tests --------- Co-authored-by: hieptl <hieptl.developer@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com> |
||
|
|
fe94fedd00 |
fix(acp): show model picker on cloud home screen; hide Code/Plan for ACP (#1296)
* fix(acp): show model picker on cloud home screen and hide Code/Plan for ACP conversations The `backend.kind !== "cloud"` guard on `showAcpPicker` was added when cloud backends ran OpenHands agents (not ACP). Now that the cloud pivot makes cloud conversations ACP, the guard was too broad: - Home screen: switching updates settings via PATCH (no agent-server call needed) → safe to show the picker on cloud home screen. - Mid-conversation cloud: the OpenHands app-server has no `/switch_acp_model` endpoint, so the picker is still suppressed there. Also fixes two cloud-specific regressions: - `conversation.llm_model` is null for ACP conversations (model lives in the ACP subprocess); add a fallback to settings-configured or provider default so the model chip stays visible after a conversation is created on cloud. - `showChangeAgentButton = isCloud` showed Code/Plan for cloud ACP conversations where it doesn't apply; guard it with `!isAcpContext`. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(acp): enable mid-conversation model picker for cloud ACP backends Now that OpenHands has a switch_acp_model proxy endpoint (#14744), route cloud mid-conversation ACP model switches through callCloudProxy instead of throwing. This lets the canvas show the full model picker (not just display+Settings) for cloud ACP conversations. Also removes the backend import from useChatInputModelState which is no longer needed now that showAcpPicker has no backend-kind guard. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix tests: update cloud ACP picker tests to match new behavior The cloud-backend guard on showAcpPicker was removed so that cloud ACP conversations can mid-conversation model switch via callCloudProxy. Two tests were asserting the old (suppressed) behavior and need updating: - use-chat-input-model-state.test.tsx: cloud backend suppresses the picker -> cloud backend shows the picker when a model list is present - chat-input-model.test.tsx: does not offer selectable rows on a cloud backend -> offers selectable rows on a cloud backend for ACP conversations Both tests still validate the full picker contract (model list, selected row, link) rather than a degraded display-only state. --------- Co-authored-by: Debug Agent <simon@openhands.dev> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: openhands <openhands@all-hands.dev> |
||
|
Hiep Le
|
28be9534e5 | chore: remove orphaned repository-selection dir and unused pagination/interactive-chip UI (#1234) | ||
|
Hiep LeandTim O'Farrell
|
797069d9bf |
chore: drop stale git-settings.tsx include from tsconfig.lib.json (#1240)
Co-authored-by: Tim O'Farrell <tofarr@gmail.com> |
||
|
Hiep Le
|
fbcb8084d7 | chore: drop dead constants, inert VITE_WORKER_URLS plumbing, and needless exports (#1238) | ||
|
Tim O'Farrellandopenhands
|
e65a07dcad |
Bump extensions to latest version (#1294)
Co-authored-by: openhands <openhands@all-hands.dev> |
||
|
|
3e311312b6 |
feat: feature 3 proven workflows, group the rest under Beta (#1259)
* feat: feature 3 proven workflows, group the rest under Beta * chore: Remove PR-only artifacts --------- Co-authored-by: allhands-bot <allhands-bot@users.noreply.github.com> Co-authored-by: Tim O'Farrell <tofarr@gmail.com> |
||
|
Hiep Le
|
7f42eb9857 | chore: remove dead upload-path remnants (#1236) | ||
|
Hiep Le
|
10f622a430 | chore: remove one-off migration codemods, demo recorder, and unused beep asset (#1232) | ||
|
Hiep Le
|
196352f84c | chore: remove dead test artifacts (#1229) | ||
|
Hiep Le
|
ac50a9c213 | chore: remove orphaned legacy modules left over from the frontend port (#1227) | ||
|
Hiep Le
|
969fcceea4 | fix: fetch cloud git changes/diff via app-conversations endpoints (#1225) | ||
|
|
dcf469855a |
UI polish: drawer tabs, empty states, and browser chrome (#1288)
* chore: bump version to 1.0.0-beta.1 * chore: publish beta and rc versions as 'latest' dist-tag * chore: bump version to 1.0.0-beta.2 * fix: use X-Session-API-Key for local automation auth in prompts and RUNTIME_SERVICES (#999) Fixes #980 The agent prompt in recommended-automations-launcher and the RUNTIME_SERVICES block in agent-server-adapter both advertised X-API-Key as the auth header for the local automation backend. The automation service (openhands-automation) does not accept X-API-Key — it accepts Authorization: Bearer and X-Session-API-Key. X-Session-API-Key is the established local convention: the agent server uses it, the frontend automation API client uses it (with an explicit comment that both backends share the same header), and auth.py describes it as matching that convention. Update both call sites and the corresponding test assertion to use X-Session-API-Key. Co-authored-by: openhands <openhands@all-hands.dev> * feat: reuse mock-LLM E2E tests for Docker image validation (#992) * feat: reuse mock-LLM E2E tests for Docker image validation Add a Docker-specific Playwright config (playwright.mock-llm-docker.config.ts) that runs the exact same test specs and helpers against the agent-canvas Docker image instead of the npm build path (bin/agent-canvas.mjs + uvx). Key changes: - Split MOCK_LLM_BASE_URL into two constants in mock-llm-helpers.ts: - MOCK_LLM_BASE_URL: always host-local, used by tests for admin API - MOCK_LLM_AGENT_URL: env-overridable, used when configuring the LLM profile (the URL the agent-server uses for inference). Defaults to MOCK_LLM_BASE_URL for backward compatibility with the npm path. - New playwright.mock-llm-docker.config.ts: - Starts the mock LLM server on the host (same as npm path) - Runs the Docker container with --network host (Linux CI) - Points to the same testDir (tests/e2e/mock-llm/) and specs - Separate output dirs to avoid collision with npm path results - New CI workflow (.github/workflows/mock-llm-docker-e2e.yml): - Builds the Docker image from current code (or uses a pre-built image) - Runs the same specs against the container - Posts PR comment with differentiated report title - render-mock-llm-report.mjs: accept --title flag for Docker vs npm reports - npm run test:e2e:mock-llm:docker script added - .gitignore updated for docker test output dirs The npm path (test:e2e:mock-llm) is fully backward-compatible — no env var override needed since MOCK_LLM_AGENT_URL defaults to MOCK_LLM_BASE_URL. Co-authored-by: openhands <openhands@all-hands.dev> * refactor: chain Docker E2E off existing Docker CI via workflow_run Instead of rebuilding the Docker image in the E2E workflow (duplicating ~10-15 min of Docker build time), use workflow_run to trigger automatically after the existing 'Docker' workflow completes successfully. The workflow now: - Triggers on: workflow_run (Docker completed) + workflow_dispatch (manual) - Derives the image tag from the Docker build's commit SHA (ghcr.io/openhands/agent-canvas:sha-<short>-amd64) - Pulls the already-built image from GHCR — no rebuild needed - Checks out code at the same SHA as the Docker build - Extracts PR number from workflow_run.pull_requests[] for comments Removed: Docker build steps, Buildx setup, build-arg resolution. All image building stays in docker.yml where it belongs. Co-authored-by: openhands <openhands@all-hands.dev> * fix: replace flaky 1s timeout with polling for Active badge assertion The 'Active badge' check in step 2 used a hardcoded 1-second waitForTimeout before reloading. On a loaded CI runner the profile activation mutation may not persist in time, causing the reload to show stale state. This is a pre-existing flake (identical test code passed on the first push and failed on the second). Replace with expect.poll() that retries the reload+check cycle with increasing intervals (1s, 2s, 3s) up to 15 seconds total. Co-authored-by: openhands <openhands@all-hands.dev> * fix: add pull_request trigger for Docker E2E (workflow_run bootstrap) workflow_run only fires when the workflow file exists on the default branch (main). Since mock-llm-docker-e2e.yml is new and only on the PR branch, GitHub doesn't recognize it as a workflow_run listener yet. Add pull_request trigger (gated by 'e2e-tests' label, skip forks) that polls the Docker workflow via gh API until it completes for the PR's head SHA, then pulls the already-built image from GHCR and runs tests. After merge, workflow_run takes over as the primary automatic trigger. The pull_request path remains as a fallback for label-gated runs. Co-authored-by: openhands <openhands@all-hands.dev> * fix: add FILE_STORE, AUTOMATION_BASE_URL, AUTOMATION_WORKSPACE_BASE to Docker entrypoint The Docker entrypoint was missing several environment variables that the npm path (dev-with-automation.mjs) sets for the automation backend: - FILE_STORE=local — without this, the automation backend may fall back to cloud storage (S3/GCS) which fails without credentials, causing tarball- based presets (preset/prompt, preset/plugin) to silently error - LOCAL_STORAGE_PATH — where to store files on the local filesystem - AUTOMATION_BASE_URL — publicly-reachable base URL for callback URLs - AUTOMATION_WORKSPACE_BASE — where automation runs unpack tarballs This explains the Docker E2E failure: the agent's curl to create an automation via /api/automation/v1/preset/prompt returned an error (likely 500 from missing storage config), but the mock LLM doesn't care about terminal output and proceeded to return the scripted final reply. The test then found 0 automations. Co-authored-by: openhands <openhands@all-hands.dev> * fix: exclude auth-modes spec from Docker E2E tests The mock-llm-auth-modes.spec.ts tests npm-binary-specific --auth-required behaviour (a second static-server instance on port 18301). The Docker image doesn't provide this second server — it has its own auth handling. Exclude the spec from the Docker test run via testIgnore. Co-authored-by: openhands <openhands@all-hands.dev> * feat: run auth-modes tests inside Docker via PUBLIC_MODE_PORT Instead of excluding the auth-modes spec from the Docker E2E run or spinning up a host-side static server with a duplicate build/ directory, the Docker entrypoint now supports an optional PUBLIC_MODE_PORT env var. When set, entrypoint.sh starts a second static-server instance from the same baked-in frontend assets with --auth-required (no session key injected). This tests the actual Docker image's auth gate behaviour — not a host-side approximation. The Playwright Docker config passes -e PUBLIC_MODE_PORT=18301 to the container and exports MOCK_LLM_PUBLIC_MODE_URL so the auth-modes spec can reach it. With --network host the port is accessible from the host. Co-authored-by: openhands <openhands@all-hands.dev> * address review feedback: drop unlabeled trigger, improve error messages, document env vars - Drop 'unlabeled' from pull_request trigger types to avoid wasted workflow runs when any label is removed (the job-level if: condition would skip immediately anyway) - Distinguish 'no Docker run found' vs 'didn't complete in time' in the polling loop's final error message - Add comment explaining /api/automation/v1 probe returns 200 without auth so the readiness check won't spin for 180s - Document FILE_STORE, LOCAL_STORAGE_PATH, AUTOMATION_BASE_URL, and AUTOMATION_WORKSPACE_BASE in the entrypoint header — these affect production deployments, not just E2E tests Co-authored-by: openhands <openhands@all-hands.dev> --------- Co-authored-by: openhands <openhands@all-hands.dev> * chore: bump version to 1.0.0-beta.3 * ci: trigger CI on rel-* branch pushes for tag protection rule (#1004) The Release Tag ruleset requires test-and-build (ubuntu) to pass before v* tags can be pushed, but CI previously only ran on main and pull_request events. This caused rel-* version bump commits to fail the tag protection check unless a workaround PR was opened. Co-authored-by: openhands <openhands@all-hands.dev> * chore: bump version to 1.0.0-beta.4 * chore: auto-graduate npm dist-tag from latest to per-tier once first stable release ships (#1028) * chore: always publish to npm with --tag latest until first stable release All alpha/beta/rc versions now get the 'latest' dist-tag so plain 'npm install @openhands/agent-canvas' always resolves to the newest published release. The per-tier dist-tags (alpha/beta/rc) can be re-introduced once the first full stable version is ready to ship. Co-authored-by: openhands <openhands@all-hands.dev> * chore: auto-graduate npm dist-tag when first stable release ships At publish time, query npm for any published version without a pre-release suffix. If none exists, all releases (alpha/beta/rc/stable) use --tag latest so plain 'npm install' always resolves to the newest build. Once a stable version has been published, pre-release versions revert to their own dist-tags (alpha/beta/rc) automatically — no workflow change required. Co-authored-by: openhands <openhands@all-hands.dev> --------- Co-authored-by: openhands <openhands@all-hands.dev> * chore: bump version to 1.0.0-beta.5 * feat(mcp): render markdown links in helperText; update Slack catalog pin (#1012) * feat(mcp): render markdown links in helperText; bump extensions to slack field-order PR commit - Add renderHelperText() to install-server-modal.tsx that converts [text](url) patterns into <a> elements with target=_blank, so the Slack workspace-ID helper text (and any future catalog entries) can embed clickable docs links inline. - Bump @openhands/extensions to commit 2d43e9c (branch slack-catalog-field-order-and-helper-links, PR #285) which: • moves SLACK_TEAM_ID before SLACK_BOT_TOKEN in the install modal • replaces the plain SLACK_TEAM_ID helper text with linked copy: 'First visit [here](...#find-your-url) to get your Slack URL and then visit [here](...#find-your-workspace-or-org-id) to get your workspace ID.' - Removes stale integrity hash from package-lock.json for the @openhands/extensions entry; npm install will recompute it. Co-authored-by: openhands <openhands@all-hands.dev> * chore: bump @openhands/extensions to d186872 (SLACK_BOT_TOKEN helperText) Add inline linked helperText for SLACK_BOT_TOKEN in slack.json (PR #285, commit d186872): 'You'll need to create or update a Slack App as shown [here](https://github.com/zencoderai/slack-mcp-server#slack-bot-setup).' Drops the now-redundant helperLink field. Co-authored-by: openhands <openhands@all-hands.dev> * chore: bump @openhands/extensions to b45d3a1 (SLACK_TEAM_ID helperText rewrite) Update SLACK_TEAM_ID helperText to named links: 'First get your [Slack URL](...). Then use that to get your [Workspace ID](...).' Co-authored-by: openhands <openhands@all-hands.dev> * chore: bump @openhands/extensions to 84a0a6e (SLACK_BOT_TOKEN named link) Update SLACK_BOT_TOKEN helperText to: "You'll need to create or update a [Slack App](...#slack-bot-setup)." Co-authored-by: openhands <openhands@all-hands.dev> * chore: bump @openhands/extensions to e07f427 (SLACK_BOT_TOKEN helperText) Update SLACK_BOT_TOKEN helperText to: "You'll need to create or update a [Slack App](...) to get a Bot token" Co-authored-by: openhands <openhands@all-hands.dev> * chore: bump @openhands/extensions to 5efd1b8 Sync to latest commit on slack-catalog-field-order-and-helper-links (PR #285). Co-authored-by: openhands <openhands@all-hands.dev> * chore: bump @openhands/extensions to 952c759 Sync to latest commit on slack-catalog-field-order-and-helper-links (PR #285). Co-authored-by: openhands <openhands@all-hands.dev> * chore: bump @openhands/extensions to f30dbfb Sync to latest commit on slack-catalog-field-order-and-helper-links (PR #285). Co-authored-by: openhands <openhands@all-hands.dev> * chore: bump @openhands/extensions to 02715f4 Sync to latest commit on slack-catalog-field-order-and-helper-links (PR #285). Co-authored-by: openhands <openhands@all-hands.dev> * chore: bump @openhands/extensions to cb092c8 Sync to latest commit on slack-catalog-field-order-and-helper-links (PR #285). Co-authored-by: openhands <openhands@all-hands.dev> * fix(mcp): validate URL scheme in renderHelperText; use matchAll - Guard href against javascript:/data: XSS via /^https?:\/\//i test - Replace exec-in-while with matchAll to drop the eslint-disable comment Addresses review bot feedback on PR #1012. Co-authored-by: openhands <openhands@all-hands.dev> * fix(mcp): use double quotes for fallback href to satisfy Prettier Co-authored-by: openhands <openhands@all-hands.dev> * chore: update @openhands/extensions to latest main (62594156) Co-authored-by: openhands <openhands@all-hands.dev> --------- Co-authored-by: openhands <openhands@all-hands.dev> * chore: bump version to 1.0.0-beta.6 * chore: bump version to 1.0.0-beta.7 * fix(mcp): drop duplicate renderHelperText after main merge * chore: bump version to 1.0.0-beta.8 * docs: update README version to 1.0.0-beta.8 * fix: default LLM setup to Anthropic Claude Opus 4.8 (#1089) * chore: bump version to 1.0.0-beta.9 * docs: update README version to 1.0.0-beta.9 * docs: update README.windows.md version to 1.0.0-beta.9 * fix(dev): align Vite dev origin with ingress and add chat footer padding Route modules loaded from :3001 while the app opened on :8000, causing blank screens on npm run dev. Point Vite server.origin/HMR at the ingress URL and add bottom spacing under the archived conversation banner footer. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(ui): polish spinners, settings empty states, and archived conversation UX Remove grey track rings from all loading spinners so only the animated arc remains visible. Wrap bare settings empty/error messages (SDK schema unavailable, profile load failures, empty profiles/skills/secrets/MCP) in the shared bordered empty-state container for visual consistency. Canonicalize 127.0.0.1 backend URLs to localhost so health probes reach the ingress proxy instead of Vite HMR on macOS dual-stack dev stacks, and sync stored default-local backend host alongside the session key. Disable conversation controls for archived sandboxes (MISSING/ERROR) with tooltips explaining unavailability, using shared archive-status helpers. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(ui): restore light foreground on conversation tab loading state Use the semantic text-foreground token for the spinner and label so loading copy stays readable on the dark surface background. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(ui): polish conversation tab loading and automations empty state Conversation tab loading: - Use TextShimmer on the loading label (same treatment as message sending) with block w-full text-center so the sweep flows across the word, not per character - Keep the spinner on text-tertiary-light for readable secondary grey - Add ConversationTabContentCrossfade to cross-fade between loading and loaded content (agent init and lazy tab chunks); content preloads underneath at opacity 0 while the overlay fades out over 350ms; reduced-motion falls back to an instant swap Automations empty state: - Add a top border above the create-instructions section to separate it from the hint copy Co-authored-by: Cursor <cursoragent@cursor.com> * fix(ui): unify drawer empty/loading states and polish browser/files tabs Align Changes, VS Code, and runtime waiting states with shared drawer patterns, add browser chrome bar with inactive nav when empty, and improve Files tab empty state and tree toggle icon. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(ui): remove browser screenshot rounding and improve panel fill Drop rounded corners on the screenshot viewer and use min-h-0 flex layout so the browser tab fills the drawer edge-to-edge and collapses correctly. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(ui): polish protip banner, browser chrome, and tab crossfade Hide non-functional browser nav controls, restyle the changes-tab protip with icon and muted subtext, drop Customize label colons, and fix Suspense fallback setState during render. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(ui): move VS Code to files toolbar and refresh drawer icons Relocate editor access from the drawer Code tab into a bordered Files toolbar button, swap tab icons to Lucide, add a terminal empty state, and update the VS Code logo asset. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(ui): animate drawer tab label reveal and icon shifts Use Framer Motion layout transitions so the active tab label expands in and sibling icons slide smoothly when switching drawer tabs. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(ui): pin VS Code in drawer tab row and fix tab drag animation Move VS Code to the drawer header, portal the overflow menu so it is not clipped, and disable tab layout animations while resizing the panel so icons only animate on click. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(ui): shrink drawer tab icons to match standard chrome size Use h-4 w-4 for drawer tab icons so they align with the ellipsis and other inline controls in the top row. Co-authored-by: Cursor <cursoragent@cursor.com> * feat(home): allow changing repo, branch, or workspace before launch Replace static git-control-bar link chips on the home screen with the same dropdowns used in the open-workspace and open-repository dialogs so users can revise their selection until they send the first message. Co-authored-by: Cursor <cursoragent@cursor.com> * Revert "feat(home): allow changing repo, branch, or workspace before launch" This reverts commit 569bf18bd18dbbe2bd2eaec5747737a162079e0e. * refactor: remove unrelated files * refactor: remove unrelated files * refactor: remove unrelated files * refactor: remove unrelated files * refactor: remove unrelated files * refactor: vscode tab --------- Co-authored-by: openhands <openhands@all-hands.dev> Co-authored-by: Tim O'Farrell <tofarr@gmail.com> Co-authored-by: Rohit Malhotra <rohitvinodmalhotra@gmail.com> Co-authored-by: chuckbutkus <chuck@openhands.dev> Co-authored-by: Hiep Le <69354317+hieptl@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: hieptl <hieptl.developer@gmail.com> |
||
|
Engel Nyst
|
77a8decca9 |
Add PR description readiness check (#1179)
* Add PR description readiness check |
||
|
Rohit Malhotraandopenhands
|
b969162027 |
test(mock-llm): add E2E coverage for Files tab, Git control bar, and Browser tab (#1029)
* test(mock-llm): add E2E coverage for Files tab, Git control bar, and Browser tab Add mock-LLM E2E tests exercising conversation panel tabs and git integration against the real agent-server: - Files tab defaults to diff view when a workspace is attached (selected_workspace seeded in conversation metadata localStorage) - Files tab defaults to file-tree view when NO workspace is attached - Git control bar shows workspace-name pill for folder-attached conversations - Browser tab renders empty state when no page has been browsed All tests run serial in a single describe block, sharing one conversation for the workspace-attached cases (steps 3-5) and creating a fresh conversation for the no-attachment case (step 6). Issue #511 Co-authored-by: openhands <openhands@all-hands.dev> * fix(test): reset mock LLM trajectory before each conversation creation The mock-LLM E2E test failed because the default 2-turn trajectory was exhausted by preceding test suites (automation, conversation). After exhaustion every /chat/completions returns 500, so the agent never produces REPLY_TOKEN and waitForNonUserMessageText times out. Fix: call resetMockLLM(request) at the top of step 2 and step 6 (before each conversation creation), matching the pattern used by mock-llm-conversation.spec.ts step 3. Co-authored-by: openhands <openhands@all-hands.dev> * fix(ci): report timeout instead of '0/0 passed' when test suite is killed When the CI wrapper kills Playwright after the 5-minute deadline (exit code 124), no results.json or marker files exist. Previously the PR comment showed '0/0 passed' with an empty table, which was misleading. Now the render script accepts --exit-code from the workflow. When exit code is 124 and no results exist, it renders a clear timeout entry: '⏱️ (test suite timed out before completing)' with a note pointing to workflow logs. Both mock-llm-e2e.yml and mock-llm-docker-e2e.yml pass the exit code through. Co-authored-by: openhands <openhands@all-hands.dev> * fix(test): re-seed workspace metadata in each test step Each Playwright test() gets a fresh browser context, so localStorage from step 2 is gone when steps 3-5 run. Extract seedWorkspaceMetadata() helper and call it in steps 3 and 4 (which assert on workspace-dependent UI: git control bar name pill and files tab diff-view default). Co-authored-by: openhands <openhands@all-hands.dev> * fix(test): assert git control bar buttons instead of workspace name The agent-server creates conversation worktrees inside the agent-canvas repo, so git detection always finds the real repo ('OpenHands/agent-canvas') and the workspace-name fallback ('my-app') never renders. Assert that Pull/Push buttons are visible instead — these only appear when the git control bar has successfully detected a repository. Co-authored-by: openhands <openhands@all-hands.dev> * fix(test): retry ensureMockLLMProfile on transient socket failures The automation spec's step 1 intermittently fails with 'socket hang up' on GET /api/settings because the agent-server briefly drops connections between test suites (while processing cleanup from the previous spec's afterAll). Add retryOnTransient() helper that retries up to 5 times (1s delay) on socket hang up, ECONNRESET, ECONNREFUSED, 502, and 503. Apply it to both the GET and PATCH calls in ensureMockLLMProfile. Co-authored-by: openhands <openhands@all-hands.dev> * fix(static-server): handle WebSocket proxy socket errors The static-server's proxyWebSocket function was missing error handlers on the piped client/backend sockets. When a WebSocket connection tears down abruptly during test cleanup (ECONNRESET, EPIPE), the unhandled 'error' event crashes the Node.js process, killing the Docker container and causing ECONNREFUSED for all subsequent tests. Add .on('error') handlers to both proxySocket and socket, matching the pattern already used in ingress.mjs (lines 273-278). Co-authored-by: openhands <openhands@all-hands.dev> * fix(test): make git control bar assertion work in npm and Docker In the npm path the agent-server creates worktrees inside the host repo so git detection finds 'OpenHands/agent-canvas' and shows Pull/Push buttons. In the Docker path there's no git repo inside the container, so the git control bar only shows the workspace name pill. Use Playwright's locator.or() to assert on whichever indicator appears: Pull button (npm) or workspace basename text (Docker). Re-add seedWorkspaceMetadata so the Docker path has a workspace name to show. Co-authored-by: openhands <openhands@all-hands.dev> * fix(test): use git-init trajectory for cross-environment git detection Instead of making the test assertion fuzzy, ensure the conversation workspace is always a proper git repo. Register a custom trajectory that runs 'git init && git commit' when no repo exists (Docker path) and skips init when already inside a git worktree (npm path). This lets the git control bar consistently show Pull/Push buttons in both environments, making the assertion deterministic. Co-authored-by: openhands <openhands@all-hands.dev> * fix(test): add git remote in trajectory for Pull/Push button detection The git control bar shows Pull/Push only when it can parse a provider+repository from 'git remote get-url origin'. A bare git init without a remote means the buttons never appear. Update the trajectory to add a fake GitHub remote when bootstrapping a new repo (Docker path). Skip when the workspace already has an origin remote (npm path — inherits the host repo). Co-authored-by: openhands <openhands@all-hands.dev> * fix(test): fix shell syntax in git bootstrap trajectory The if/then/else joined with spaces produced invalid bash: 'then true else' (missing semicolons). Rewrite using || operator which avoids the issue entirely. Also increase Pull button timeout to 25s since useLocalGitInfo polls every 10s. Co-authored-by: openhands <openhands@all-hands.dev> * fix(test): assert workspace pill as primary gate, soft-check Pull/Push The useLocalGitInfo probe requires a connected bash WebSocket that may not be available in Docker after agent completion. The workspace pill ('my-app') is the primary user-facing behavior for folder-attached conversations and renders reliably from localStorage. Make the workspace pill the hard assertion (primary gate). Treat Pull/Push buttons as a soft check that logs a message instead of failing when the git probe hasn't completed in time. Co-authored-by: openhands <openhands@all-hands.dev> * fix(test): increase diff toggle assertion timeout for Docker API latency The toHaveAttribute('aria-checked', 'true') assertion had only a 5s timeout. useHasAttachedSource depends on useActiveConversation fetching the conversation API first — in Docker the round-trip can be slower. Increase to 15s so the React Query response has time to arrive and trigger the re-render that flips the toggle. Co-authored-by: openhands <openhands@all-hands.dev> * fix(test): configure git user in Docker trajectory for commit to work git commit --allow-empty fails in Docker containers without user.name and user.email configured. Add git config commands to the bootstrap trajectory so the initial commit actually creates a HEAD ref. Without a valid commit, useHasGitCommits returns false and the diff toggle defaults to off — matching the design ('no commits means no diff base') but not the test expectation. Co-authored-by: openhands <openhands@all-hands.dev> * fix(test): make diff toggle test environment-agnostic In Docker, useHasGitCommits may not fire (workspace.working_dir may be absent or the bash probe may not execute for finished conversations). This causes the diff toggle to default to 'off' instead of 'on'. Rather than asserting a specific default, verify: 1. Both toggle options render (diff on / diff off) 2. Clicking 'on' switches the toggle to checked state This still exercises the full Files tab rendering pipeline and toggle interactivity without being fragile to the git probe's environment dependencies. Co-authored-by: openhands <openhands@all-hands.dev> * fix(test): add animation waits before panel/tab interactions The right panel uses a 300ms CSS transition. Clicking the diff toggle immediately after opening the panel causes click interception by the animation overlay in Docker. Add explicit waits after panel open and tab switch clicks. Co-authored-by: openhands <openhands@all-hands.dev> * fix(test): robust panel/tab/toggle waits + force click in step 4 - Wait for tab bar visibility (proves panel animation completed) - Wait for diff toggle itself (not the files-tab container which may be 'hidden' during CSS transition) - Use force click to bypass residual animation overlay - Simplify into a single test.step Co-authored-by: openhands <openhands@all-hands.dev> * fix(e2e): use parent toggle container instead of .or() to avoid strict mode violation The SegmentedToggle renders both option buttons simultaneously as a radio group. Using .or() on two always-visible elements triggers Playwright's strict mode ('resolved to 2 elements'). Wait for the parent radiogroup container (files-tab-diff-toggle) instead. Co-authored-by: openhands <openhands@all-hands.dev> * fix(e2e): wait for diff toggle instead of files-tab container in step 6 The files-tab main container reports 'hidden' during the right-panel drawer animation. Wait for the inner diff toggle radio group (same approach as step 4) which is visible once the tab content renders. Co-authored-by: openhands <openhands@all-hands.dev> * chore: address review feedback — trim verbose comments, fix dead code - Trim seedWorkspaceMetadata JSDoc to keep only the addInitScript timing note - Remove self-evident 're-seed' comments in steps 3 and 4 - Trim step 1 trajectory block comment to two lines - Remove step 2 seed rationale comment (function name is sufficient) - Remove box-header section dividers added in this PR - Fix unreachable throw in retryOnTransient via lastError pattern - Tighten retryOnTransient JSDoc to just list the retried conditions Co-authored-by: openhands <openhands@all-hands.dev> * ci: increase Docker E2E timeout from 15 to 25 minutes The 15-minute job timeout is too tight for PR-triggered runs that must first wait for the Docker workflow to complete (up to ~5 min) and then pull the image (up to ~12 min with a cold runner cache), leaving no room for setup and test execution. Successful PR runs already take 12-13 minutes typically. With an unlucky cold Docker cache (observed on the 04:11 UTC run for PR 1029), the image pull alone took 11+ minutes, causing the job to hit the 15-minute timeout before tests even started. Increasing to 25 minutes provides sufficient headroom for: - Docker workflow wait: ~3-5 min typical - Docker image pull (cold cache): up to ~12 min - Test infrastructure setup: ~2 min - Playwright test execution: ~6-7 min Co-authored-by: openhands <openhands@all-hands.dev> * Apply suggestion from @malhotra5 --------- Co-authored-by: openhands <openhands@all-hands.dev> |
||
|
chuckbutkusandopenhands
|
f93cb3c9ee |
settings: persist app preferences and disabled_skills on the agent-server (#1191)
* settings: persist app preferences and disabled_skills on the agent-server The local agent-server now exposes app_preferences on the persisted settings (OpenHands/software-agent-sdk#3539): language, sound notifications, analytics consent, git identity, and disabled_skills are returned on GET /api/settings under app_preferences and updated via a new app_preferences_diff field on PATCH /api/settings. This brings the local agent-server to parity with the cloud, which has always accepted the same keys at the top level. Drops the localStorage workaround that mirrored these fields in two keys (openhands-agent-server-app-preferences and openhands-agent-server-disabled-skills), along with the app-preferences-store.ts module and the DISABLED_SKILLS_STORAGE_KEY helpers it depended on. - SettingsService.transformApiResponse reads app_preferences from the server response and hoists each field onto the flat Settings shape so consumers (settings.language, settings.disabled_skills, …) keep working unchanged. - SettingsService.saveSettings routes the same set of fields through the new app_preferences_diff for local backends and through the existing app_preferences flat-spread path for cloud backends. - New legacy-app-preferences-migration.ts runs once on first getSettings() after upgrade: when the server reports an app_preferences block AND legacy localStorage values are still present, it pushes them up via app_preferences_diff and clears the legacy keys. Pre-1.27 servers (which omit app_preferences entirely) cause the migration to no-op so existing data isn't dropped before the server can accept it. - Updated MSW handlers to round-trip app_preferences and app_preferences_diff so the mock backend matches production. - Test coverage: 5 new tests in __tests__/api/settings-service.test.ts for the local round-trip, the mixed diff routing, the legacy migration, and the pre-1.27 skip path. Closes the localStorage workaround called out in the recent audit of agent-canvas localStorage usage (items 3 and 4: disabled_skills and app-preferences fields). Depends on agent-server 1.27 / SDK PR #3539. Co-authored-by: openhands <openhands@all-hands.dev> * settings: read/write app preferences via misc_settings container Follow-up to the localStorage cleanup in this PR + SDK refactor in openhands/software-agent-sdk#3543. The agent-server now exposes frontend-owned settings under a generic misc_settings container instead of a top-level app_preferences field. Wire shape changes: Before: After: GET /api/settings GET /api/settings -> { app_preferences: {...} } -> { misc_settings: { app_preferences: {...} } } PATCH /api/settings PATCH /api/settings body.app_preferences_diff (shallow body.misc_settings_diff (deep-merged, overlay, replaces named fields) same semantics as agent_settings_diff) Why the rename to misc_settings: the previous name pinned the API to a single 'frontend-owned' namespace. Adding a future category like ui_preferences (sidebar layout / view modes) would have required either yet another top-level field or shoehorning unrelated UI state into AppPreferences. With misc_settings as a container, new categories drop in as nested fields without churning the top-level shape. Changes: - settings-service.api.ts * SettingsApiResponse.app_preferences -> .misc_settings (typed) * SettingsUpdateRequest.app_preferences_diff -> .misc_settings_diff * Add MiscSettings interface * transformApiResponse reads response.misc_settings?.app_preferences * saveSettings emits { misc_settings_diff: { app_preferences } } * Local 'has any diffs' check tracks misc_settings_diff * Doc comments updated; semantics noted as deep-merge - legacy-app-preferences-migration.ts * Gate on serverResponse.misc_settings, not .app_preferences * pushDiff callback now wraps the diff in { app_preferences: ... } - src/mocks/settings-handlers.ts * GET handler returns misc_settings.app_preferences * PATCH handler accepts misc_settings_diff; deep-merges nested app_preferences into the persisted block * Internal mock state stores under misc_settings to match wire shape - __tests__/api/settings-service.test.ts * Four tests updated to assert the new wire shape (local PATCH body, GET round-trip, mixed-diff routing, legacy localStorage migration) * Pre-1.27 detection test now keys off missing misc_settings - AGENTS.md * App-preferences note rewritten for the misc_settings container, explains deep-merge semantics, and documents the in-flight rename (flat shape introduced in #3539 never shipped to users) Cloud path is unchanged: cloud /api/v1/settings still accepts the fields as flat top-level keys, mirrored by saveCloudSettings. Verification: $ npm run typecheck exit 0 $ npm test -- __tests__/api/settings-service.test.ts \ __tests__/api/mock-settings-handlers.test.ts 23 tests passed $ npm test 3009 passed | 12 skipped | 9 todo $ npm run lint All matched files use Prettier code style! $ npm run build built in 1.50s Co-authored-by: openhands <openhands@all-hands.dev> * Bump agent-server default to 1.27.0 Co-authored-by: openhands <openhands@all-hands.dev> --------- Co-authored-by: openhands <openhands@all-hands.dev> |
||
|
Rohit Malhotraandopenhands
|
8c2cc3997d |
fix: GitHub MCP server works in Docker without Docker-in-Docker (#1282)
* fix: GitHub MCP server works in Docker without Docker-in-Docker
The GitHub MCP catalog entry uses `docker run` as its transport command,
which fails inside the agent-canvas Docker container because Docker is not
available (no daemon, no CLI). This is the only MCP integration affected —
all others use `npx` or `uvx`.
Fix:
- Pre-install the `github-mcp-server` Go binary in the Docker image via a
new multi-arch download stage (supports amd64/arm64)
- Export `getDeploymentMode()` from agent-server-adapter to expose the
runtime services info mode ("docker", "dev:automation", etc.)
- Add `patchGitHubEntry()` in mcp-marketplace-utils.ts that rewrites the
catalog entry from `docker run … ghcr.io/github/github-mcp-server` to
`github-mcp-server stdio` when deployment mode is "docker"
- The patch follows the existing `patchLinearEntry` pattern: immutable
spread, conditional on entry id, wired into `getMcpMarketplaceCatalog()`
Closes #1190
* docs: document GitHub MCP catalog patching in AGENTS.md
Co-authored-by: openhands <openhands@all-hands.dev>
* test: add E2E test for GitHub MCP install flow via marketplace UI
Exercises the full MCP page UI flow:
- Navigate to /mcp, verify GitHub marketplace card is visible
- Open install modal, verify fields (command, PAT input)
- Validate empty PAT shows error
- Fill PAT, submit with mocked /api/mcp/test success, verify installed
- Delete installed server via toggle + confirmation modal
Intercepts POST /api/mcp/test to return mock success since the real
github-mcp-server binary is not available in the test environment.
Co-authored-by: openhands <openhands@all-hands.dev>
* chore: track github-mcp-server version in config/defaults.json
Move the hardcoded GITHUB_MCP_SERVER_VERSION=1.2.0 from the Dockerfile
default into config/defaults.json (versions.githubMcpServer) alongside
the other external dependency pins.
- Dockerfile: ARG no longer has a default; CI and local builds must
pass it explicitly
- docker.yml: reads the version from config and passes it as a build-arg
- docker-build.mjs: reads the version from config and passes it too
Co-authored-by: openhands <openhands@all-hands.dev>
* fix: correct GitHub MCP binary download URL and remove flaky validation test
- Fix Dockerfile: release assets use github-mcp-server_Linux_{arch}.tar.gz
(no version in the filename), not github-mcp-server_{version}_Linux_{arch}.tar.gz
- Remove step 3 (empty PAT validation test) which relied on CSS class
selector that doesn't work reliably in Playwright with compiled Tailwind
- Renumber remaining steps (4→3, 5→4)
Co-authored-by: openhands <openhands@all-hands.dev>
* docs: address review comments — document docker command assumption and arch fallback
- mcp-marketplace-utils.ts: explain why we match on command === 'docker'
and what happens if upstream changes the catalog entry
- Dockerfile: document the *) arch fallback and when to update it
Co-authored-by: openhands <openhands@all-hands.dev>
* test: assert Docker-specific command patching in GitHub MCP E2E test
The test now asserts the command field value based on the deployment mode:
- Docker E2E: expects 'github-mcp-server stdio' (native binary)
- npm E2E: expects 'docker' (original catalog transport)
Uses MOCK_LLM_DOCKER_IMAGE env var presence (set only by the Docker
Playwright config) to determine which assertion to make. This ensures
the patchGitHubEntry runtime rewrite is exercised in Docker E2E.
Co-authored-by: openhands <openhands@all-hands.dev>
* test: add unit tests for patchGitHubEntry Docker command rewrite
Addresses review feedback to add unit test coverage for the runtime
catalog patching. Three new tests via getMcpMarketplaceCatalog:
- Non-Docker mode: GitHub entry keeps original 'docker run' command
- Docker mode: command rewritten to 'github-mcp-server stdio'
- Docker mode: other entries (Tavily) unaffected
Uses vi.mock to control getDeploymentMode return value.
Co-authored-by: openhands <openhands@all-hands.dev>
---------
Co-authored-by: openhands <openhands@all-hands.dev>
|
||
|
|
e25598c529 |
chore(acp): remove the archived-resume wake UI (#1276)
ACP should not offer resume of a fully-recycled (archived) conversation — the regular OpenHands agent doesn't. Remove the wake affordance so a recycled ACP conversation shows the same read-only 'archived' notice as every other conversation: - delete acp-resume-archived-button.tsx + use-wake-conversation.ts - remove wakeRecycledCloudConversation from cloud/conversation-service.api.ts - drop the ACP-only render branch in chat-interface.tsx (falls back to the standard archived notice) - drop the now-unused CHAT_INTERFACE$ACP_RESUME_* i18n keys Part of the agent-canvas#988 'behave like OpenHands' pivot; backend counterpart reverts bootstrap resume + enables acp_isolate_data_dir. Closes #1275. Co-authored-by: Debug Agent <simon@openhands.dev> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: openhands <openhands@all-hands.dev> |
||
|
|
254c7c9570 |
fix(acp): warn on Claude OAuth token + ANTHROPIC_API_KEY conflict too (#1279)
ACP_CREDENTIAL_CONFLICTS only listed [CLAUDE_CODE_OAUTH_TOKEN, ANTHROPIC_BASE_URL]. The SDK strips BOTH ANTHROPIC_API_KEY and ANTHROPIC_BASE_URL when the OAuth token is active (software-agent-sdk#3588), so a co-present API key is silently ignored at runtime too. Add the [CLAUDE_CODE_OAUTH_TOKEN, ANTHROPIC_API_KEY] pair so the onboarding + settings credential forms warn about it, matching the SDK behavior. Co-authored-by: Debug Agent <simon@openhands.dev> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> |
||
|
Vasco Schiavoandhieptl
|
9f201e8c02 |
feat(chat): per-tool visualizers for tool calls in the conversation UI (#1246)
* feat(chat): tool visualizer * feat(chat): tool visualizer * feat(chat): per-tool visualizers for tool calls in the conversation UI * test(chat): move tool-visualizer tests to __tests__ and drop lib-build exclude * fix(chat): correct file-edit diffs and model-switch history rendering --------- Co-authored-by: hieptl <hieptl.developer@gmail.com> |
||
|
Ismail Zalim
|
c5f793acc7 | fix: require I18nKey for translation calls (#1230) | ||
|
|
976413534d |
test(e2e): add folder browser → workspace → conversation E2E test (#1264)
* test(e2e): add folder browser → workspace → conversation E2E test Adds a mock-LLM E2E test covering the workspace selection flow from issue #511: - Browse local folders via the folder browser UI - Add a directory as a workspace - Select it in the dropdown and launch a conversation - Verify POST /api/conversations receives the correct working_dir - Verify selected_workspace is persisted in localStorage metadata Docker compat: volume-mounts the test directory into the container so the agent-server's folder browser can list it. Uses a host/container path split (MOCK_LLM_FOLDER_WORKSPACE_HOST_DIR env var) following the same pattern as the skill test mounts. Co-authored-by: openhands <openhands@all-hands.dev> * fix(e2e): address review feedback on folder-workspace test - Export MOCK_LLM_FOLDER_WORKSPACE_CONTAINER_DIR from Docker config for consistency with MOCK_LLM_SKILL_REPOS_CONTAINER_DIR pattern - Use os.tmpdir() for host-side fallback instead of hardcoding /tmp - Read container-side path from MOCK_LLM_FOLDER_WORKSPACE_CONTAINER_DIR env var (set by Docker config) with os.tmpdir() fallback for npm mode - Navigate folder browser path segments dynamically instead of hardcoding individual directory names Co-authored-by: openhands <openhands@all-hands.dev> * fix(e2e): use path.posix for container paths, assert root after nav-up - Use path.posix.join for CONTAINER_DIR_BASE and TEST_DIR since the agent-server filesystem is always POSIX (Linux container or Linux host) - Replace hardcoded 10-iteration nav-up loop with while(!disabled) plus an explicit assertion that we reached '/' before navigating down Co-authored-by: openhands <openhands@all-hands.dev> * chore: Remove PR-only artifacts --------- Co-authored-by: openhands <openhands@all-hands.dev> Co-authored-by: allhands-bot <allhands-bot@users.noreply.github.com> |
||
|
|
a248bf0e08 |
feat: render critic results in conversation events (#485)
* feat: add critic result types, component, and event rendering Migrate critic visualization from OpenHands PR #14133. Types (src/types/agent-server/core/base/critic.ts): - CriticResult — score (0-1), message, metadata - CriticFeature — name, display_name, probability - CriticCategorizedFeatures — agent_behavioral_issues, user_followup_patterns, infrastructure_issues, other - CriticMetadata — wraps categorized features and event IDs - Added optional critic_result field to ActionEvent and MessageEvent Component (critic-result-display.tsx): - Star rating (0-5) with color coding: green ≥60%, yellow ≥40%, red <40% - Percentage display - Expandable categorized feature breakdown with per-feature probabilities - Iterative refinement hint when disabled in settings - Full i18n support (15 languages) Integration: - FinishEventMessage renders CriticResultDisplay below the finish message when critic_result is present - UserAssistantEventMessage renders CriticResultDisplay for agent messages when critic_result is present Tests: - 14 unit tests covering score rendering, star ratings, color coding, label rendering, expand/collapse, iterative refinement hint, and multiple feature categories Co-authored-by: openhands <openhands@all-hands.dev> * refactor: SdkSectionPage multi-source support + verification settings Refactor SdkSectionPage to accept a `settingsSources` array instead of single `settingsSource`/`sectionKeys` props, enabling a page to render fields from multiple schema sources (e.g. both agent_settings and conversation_settings). Key changes: - SdkSectionPage: new `settingsSources: SettingsSourceConfig[]` prop replaces `settingsSource`/`sectionKeys`; tracks values/dirty state per source; emits combined save payload with per-source diff keys (agent_settings_diff, conversation_settings_diff) - verification-settings: simplified to declarative multi-source config pulling critic fields from agent_settings and confirmation/security fields from conversation_settings - condenser-settings, llm-settings: updated to new `settingsSources` API - Mock handlers: merged critic fields into verification section; updated defaults to match upstream schema structure - All tests updated for new API shape; full suite passes (2313 tests) Co-authored-by: openhands <openhands@all-hands.dev> * feat(verification): require user-supplied API key when enabling the critic Instead of silently reusing the OpenHands provider's LLM API key, expose a dedicated verification.critic_api_key schema field that appears (required) once the critic is enabled. The hint underneath reuses the existing OpenHands Cloud copy from the LLM provider screen so users know any LLM API key — easiest, their OpenHands Cloud key — will power the critic. - Add field to mock agent_settings schema with secret/required/critical flags and depends_on: [verification.critic_enabled]. - Extend FIELD_HELP_LINKS with an optional suffixKey so the schema- driven help row can render OpenHands Cloud copy without forking it. - Add SCHEMA$VERIFICATION$CRITIC_API_KEY$LABEL and $DESCRIPTION across all 15 locales. - Cover both enabled (field + help link visible, password, required) and disabled (field hidden) states in __tests__/routes/verification-settings.test.tsx. Co-authored-by: openhands <openhands@all-hands.dev> * ui(verification): drop critic API key into a full-width row below the toggles The two-column settings grid was placing the critic API key beside Enable Critic, leaving a tall stretch of whitespace under the toggle and squeezing the help link copy. Instead: - Reorder the mock schema so the Critic API Key field comes after Enable Iterative Refinement, freeing the right column for the second toggle on the first row. - Introduce FIELD_FULL_WIDTH_KEYS in schema-field.tsx (small UI-only set, mirrors the FIELD_HELP_LINKS pattern) and have sdk-section-page apply xl:col-span-2 to those fields. The critic API key is the only entry for now. Result in Basic view with the critic enabled: - Row 1: Enable Critic | Enable Iterative Refinement - Row 2: Critic API Key (full width, with help link) Co-authored-by: openhands <openhands@all-hands.dev> * test(snapshots): update verification helper for schema-driven page The hand-written 'Enable Confirmation Mode' header was removed when verification-settings.tsx switched to a pure SdkSectionPage, and confirmation_mode is a prominence: 'major' schema field — so it only appears in Advanced/All views. The snapshot test helper was still waiting for the old text and using the old confirmation-mode-toggle testId, which made all three verification snapshots time out. - waitForVerificationPage now waits for 'Enable Critic' (the first critical-prominence field, always visible), then clicks the sdk-section-all-toggle to switch to the 'All' view, then waits for the rendered 'Confirmation Mode' label (i18n SCHEMA$…$LABEL gives it a capital M, not the schema's raw 'Confirmation mode'). - The on/off tests use the new sdk-settings-confirmation_mode testId emitted by SchemaField's SettingsSwitch wrapper. The label-click pattern is preserved (the <input type=checkbox> is hidden by SettingsSwitch). - Security-analyzer locator is now case-insensitive (/security analyzer/i) since the i18n label is 'Security Analyzer'. Baselines will needBaselines will needBaselines will needBaselines will needBaselull-width row, and switching to the 'All' view all change the rendered pixels. Apply the 'update-snapshots' label after this commit lands. Co-authored-by: openhands <openhands@all-hands.dev> * Clarify critic API key guidance * test: snapshot verification critic settings * fix: improve critic score rendering accessibility * test: cover multi-source settings save * test: cover verification settings dedupe * style: use strict null checks in critic helper * test: cover critic result e2e rendering * test: make live critic e2e start conversation directly * test: fix live e2e llm profile setup * chore: Update PR QA artifacts --------- Co-authored-by: openhands <openhands@all-hands.dev> Co-authored-by: Rohit Malhotra <rohitvinodmalhotra@gmail.com> Co-authored-by: allhands-bot <allhands-bot@users.noreply.github.com> |
||
|
Rohit Malhotraandopenhands
|
e6e61b0fa6 |
refactor(e2e): drive mock-LLM test interactions through the UI (#1222)
Replace direct API calls for seeding/configuring state in mock-LLM E2E
tests with UI-driven interactions wherever possible, ensuring downstream
API calls are covered by the test.
Changes:
- mock-llm-profile-management.spec.ts: All three scenarios (active
profile deletion, same-model identity, litellm_proxy base_url
preservation) now create and activate profiles through the Settings →
LLM Profiles UI instead of raw POST/activate API calls. Cleanup in
afterAll uses the UI delete flow via exported deleteProfileIfExists.
- mock-llm-model-switch.spec.ts: The switch-target profile B is now
created through the Settings UI (createProfileViaUI) instead of a
raw POST to /api/profiles. Cleanup uses UI-driven deletion.
- mock-llm-skills.spec.ts: Replaced the inlined configureMockLLM()
helper (which did a raw PATCH to /api/settings) with the UI-driven
ensureMockLLMProfile(page) that creates and activates the profile
through the Settings screen.
- mock-llm-acp-agent.spec.ts: afterAll cleanup now resets agent type
back to OpenHands via the Settings → Agent UI (resetToOpenHandsAgentViaUI)
instead of a raw PATCH to /api/settings. The local selectDropdownOption
is removed in favor of the shared export from mock-llm-helpers.
- mock-llm-conversation.spec.ts: Removed the redundant API pre-check
in step 3 that verified the profile was active via GET /api/profiles.
Steps 1+2 already verified this through the UI (Active badge check).
- mock-llm-helpers.ts:
- Extracted createProfileViaUI() from ensureMockLLMProfile() as a
standalone exported helper for tests that need to create profiles
without activating them.
- Exported deleteProfileIfExists() and activateProfileViaUI() so
tests can compose profile lifecycle operations through the UI.
- Added selectDropdownOption() (consolidated from ACP spec's local copy).
- Added resetToOpenHandsAgentViaUI() for UI-driven agent type reset.
- Marked the API-based resetToOpenHandsAgent() as @deprecated.
Co-authored-by: openhands <openhands@all-hands.dev>
|
||
|
Hiep Le
|
032f441b1c |
fix: raise contrast of loading/status text on the Change/Diffs tab (#1253)
* fix: raise contrast of loading/status text on the Change/Diffs tab * refactor: update the code based on feedback * fix: lint |
||
|
|
098af964a8 |
fix(acp): single Save + auth banner + one toast on Settings → Agent (#1251)
* fix(acp): single Save + auth banner + one toast on Settings -> Agent (#988) Three follow-up UX fixes to #1102 on the Settings -> Agent ACP surface: - Single Save. The credentials section rendered its own "Save Changes" right above the page-level one — two identical buttons doing different things (secrets vs agent spec). Consolidate to one Save that persists both; the section is now presentational (the page owns the credential form via a lifted useAcpCredentialForm). A credentials-only edit saves just the secret and skips the redundant settings write. - Auth banner. Surface the onboarding "already signed in to {provider}" banner in the credentials section too, via a new shared AcpAuthStatusBanner that onboarding now also uses. Local-backend login probe only (silent on cloud/unknown), same as onboarding. - One toast. When a single Save persists both the agent spec and a credential, the credential save is silenced so the user sees one "Saved" instead of two (errors still surface). Typecheck + lint green; 50 tests across the agent-settings / credentials-section / onboarding suites pass, incl. new coverage for the single-save flow, the auth-banner states, and the single-toast assertion. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * chore: drop redundant isAcp guard on credential dirty check (#1251) acpCredentialForm.isDirty is already false off the ACP path (no credential fields), so the isAcp && guard is redundant. Per review feedback. --------- Co-authored-by: Debug Agent <debug@example.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> |
||
|
|
ec4616c1c7 |
feat(acp): containerized + cloud ACP — onboarding, secrets, and recycled-sandbox resume (#1013/#1014/#988) (#1102)
* feat(acp): containerized ACP — credential onboarding + inline secrets (#1013/#1014) Wire the canvas halves of agent-canvas#1014 (Docker) and #1013 (credential onboarding) so a user can run an ACP agent (Codex / Claude Code / Gemini) against a containerized agent-server through Canvas, with credentials supplied in the UI. Credential onboarding UX (#1013): - Extend the ACP secrets step beyond the API key to the per-provider reserved credentials a fresh container needs: Codex CODEX_AUTH_JSON, Claude CLAUDE_CODE_OAUTH_TOKEN, Gemini GOOGLE_APPLICATION_CREDENTIALS_JSON + GOOGLE_CLOUD_PROJECT/LOCATION + GOOGLE_GENAI_USE_VERTEXAI. File-content blobs render as multiline fields. - Make the step capability-driven: required on a backend with no host login (cloud, or a logged-out local/Docker backend per the auth probe), optional when a login is detected or the probe can't classify (native dev). - Fix the orphaned-secret bug: warn instead of toasting "Saved" when the active backend can't consume the credential (cloud can't yet read file secrets). Send secrets + model (start request): - buildStartConversationRequest emits reserved ACP credentials inline as StaticSecrets (overriding any same-named LookupSecret) and mirrors them onto agent_context.secrets, so the SDK's acp_file_secrets defaults materialise the *_JSON blobs before the CLI spawns. The orchestrator reads back the saved reserved values for the active provider (local backends only). - Preselect a Vertex-safe acp_model for Gemini (gemini-2.5-flash) so a fresh container doesn't hit gemini-cli's preview default that 404s on Vertex. - Never auto-promote *_BASE_URL to an inline secret (an inherited base URL breaks the Claude OAuth token's bearer auth). Docker setup + docs: - examples/acp-docker/ docker-compose (persistent volume + canvas_ui tool mount + credential notes); .env.sample + docs point VITE_BACKEND_BASE_URL at it. - docs/ACP_AGENTS.md gains a "Running ACP agents in a Docker container" section. Per-conversation isolation (acp_isolate_data_dir) left as a documented TODO — the field isn't exposed on ACPAgentSettings in the released typescript-client. Tests + e2e: - Unit tests for the StaticSecret emission, reserved-credential sets, Vertex model default, getSecretValues read-back, and the required-credentials matrix. - tests/e2e/live-acp/: a vite-node harness that builds each provider's request via buildStartConversationRequest and POSTs it to a real container. Validated with REAL API calls against agent-server c950fdb-python: Codex ✅, Claude ✅, Gemini ✅ (materialise ADC -> vertex-ai -> real reply). Gemini's default-config init is blocked by an SDK/gemini-cli set_session_mode("yolo") issue (documented caveat, not a credential problem). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(acp): make containerized credentials survive the real conversation-start path Validating end-to-end through the application's own orchestrator (buildStartConversationRequestWithEncryptedSettings) against a live container — rather than the request builder in isolation — surfaced two real bugs that would have broken the feature in the product: 1. secrets_encrypted mangled the plaintext reserved StaticSecrets. The app always fetches settings in encrypted mode, so the start request carried secrets_encrypted=true. The agent-server then runs every secret value through cipher.decrypt() during validation — including our reserved ACP creds, which are read back as PLAINTEXT. Result: the credential was silently dropped (decrypt fails → None) on a cipher backend, or a hard 500 ("cipher not configured") on a fresh container with no OH_SECRET_KEY. Fix: don't set secrets_encrypted for ACP conversations — an ACP agent has no encrypted agent secret (no LLM api_key), and its provider creds ride as plaintext StaticSecrets. 2. A different provider's leftover file-content secret broke the active provider. A CODEX_AUTH_JSON saved while onboarding Codex leaks into a later Claude conversation via the global-secrets → LookupSecret path. The SDK materialises file secrets eagerly at spawn by resolving the secret source, and a LookupSecret resolution stalls → ReadTimeout → "Failed to start ACP server: timed out". Fix: reserved file-content blobs (the multiline *_JSON creds) never travel as LookupSecrets — the active provider's is sent inline as a StaticSecret, any other provider's is dropped (getAllReservedAcpFileSecretNames). Re-validated through the app orchestrator against agent-server c950fdb-python (onboarding createSecret → buildAcpAgentSettingsDiff PATCH → orchestrator read-back → real reply): Codex ✅, Claude ✅ (leftover CODEX_AUTH_JSON correctly dropped). Gemini's app path is correct (StaticSecrets emitted, vertex-ai auth reached); this run hit the documented invalid_rapt stale-ADC caveat (host ADC expired since the prior fresh-ADC pass) — an environment issue, not code. Adds regression tests (secrets_encrypted suppressed for ACP / kept for non-ACP; leftover file blob dropped not LookupSecret'd; getAllReservedAcpFileSecretNames) and the app-path e2e harness (tests/e2e/live-acp/acp-docker-app-e2e.mts). Notes OH_SECRET_KEY as optional (secret persistence) in the compose example. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * chore: address PR review feedback (#1102) - retag acp_isolate_data_dir TODO #1014 (this PR) -> #1019 (the per-conversation isolation follow-up the knob serves) - note the Gemini Vertex scalars (PROJECT/LOCATION/USE_VERTEXAI) are plain config / a routing flag, not secrets Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(acp): order subscription credential before API key in onboarding Show each provider's reserved subscription/Vertex credential first (Claude CLAUDE_CODE_OAUTH_TOKEN, Codex CODEX_AUTH_JSON, Gemini Vertex SA), then the API key, then the base URL — the subscription token is the primary auth path for ACP providers, with the API key as the fallback. Display order only; getAcpProviderSecrets consumers are order-independent. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(i18n): disable i18next value escaping so React handles it i18next's default escapeValue double-escapes interpolated values on top of React's own escaping, rendering paths like ~/.codex/auth.json as ~/.codex/auth.json. Set interpolation.escapeValue=false (the standard react-i18next config); React still escapes at render time. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(acp): unify secret wire-delivery; keep "reserved" as onboarding-only Drop the reserved-vs-custom split in how secrets reach the agent-server. Previously, provider credentials ("reserved") rode inline as StaticSecrets while user secrets rode as loopback LookupSecrets — a fork introduced only to dodge a deadlock: the SDK resolved an ACP agent's secrets synchronously on its event loop at CLI spawn, so a loopback LookupSecret self-deadlocked. That deadlock is fixed at the source in software-agent-sdk#3510 (ACP cold-start runs off the event loop), so the workaround is no longer needed. Now every secret — env-var credential, file-content blob, or user secret — ships uniformly as a LookupSecret, for ACP and non-ACP alike. The SDK resolves and (for file blobs) materialises them off the loop, so the loopback fetch is safe. "Reserved" survives only as an onboarding/validation concept (which fields to prompt for per provider, capability-driven required steps) — it no longer affects the wire. Removed: StaticSecret type, acpStaticSecrets option + the inline path, the file-blob lookupSkip, SecretsService.getSecretValues, and the reserved-name value read-back. Kept: secrets_encrypted suppression for ACP (an ACP request carries no encrypted payload, and a fresh ACP container may have no OH_SECRET_KEY cipher). Note: getReservedAcpSecretNames / getAllReservedAcpFileSecretNames in constants/acp-providers.ts are now unused by the wire; the former is still useful for validation, the latter can be pruned. Depends on software-agent-sdk#3510. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(acp): prune now-dead reserved-secret wire helpers Follow-up to the wire-delivery unification: getReservedAcpSecretNames and getAllReservedAcpFileSecretNames were only ever consumed by the inline StaticSecret / file-blob-skip path, which is gone. They have no remaining production callers, so remove them (and their tests). The reserved-credential field definitions (ACP_RESERVED_CREDENTIALS, getAcpProviderSecrets) and the ``reserved`` / ``multiline`` flags stay — onboarding still reads them. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(acp): re-point containerized ACP at SDK 1.25.0 (#3510) + fix e2e harnesses The unified LookupSecret delivery (e076e9bb) depends on software-agent-sdk#3510 (ACP cold-start off the event loop), which first ships in v1.25.0. The example compose/docs/e2e all still defaulted to agent-server:c950fdb-python, which predates #3510 and deadlocks the first ACP turn ("Failed to start ACP server: timed out"). Bump every default to 1.25.0-python and document it as the minimum. Also realign the live-acp e2e harnesses, which still encoded the removed StaticSecret API (the PR's headline evidence predated the unification): - acp-docker-e2e.mts: store each credential via SecretsService.createSecret, send name-only customSecrets, assert every emitted secret is a LookupSecret. - acp-docker-app-e2e.mts: flip the assertion StaticSecret -> LookupSecret; drop the stale getSecretValues reference. - Both: fix a polling bug where "idle" (the transient pre-run state) was treated as terminal, so the loop bailed before the agent ran and read an empty reply. Terminal is now {finished, error, stuck, stopped}. Correct the stale StaticSecret doc comments in constants/acp-providers.ts (reserved is now an onboarding/validation marker, not a wire distinction). Re-validated in-container against agent-server:1.25.0-python: Codex and Claude pass end-to-end on both harnesses (LookupSecret resolves off-loop, no deadlock, even with leftover cross-provider file-secrets present). Gemini's credential path is proven (vertex-ai auth reached) but the turn is blocked by gemini-cli 0.45.x ignoring the requested acp_model and running gemini-3-flash — an SDK model-selection concern tracked in software-agent-sdk#3532, not a Canvas bug; the docs/e2e notes are corrected accordingly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(acp): improve credential hint text with fetch commands Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * feat(acp): show provider credentials in Settings → Agent Adds a Credentials section to /settings/agent when an ACP provider is selected, so users can set or rotate tokens/keys after onboarding without hunting through Settings → Secrets. Mirrors the onboarding fields exactly (same hints, same already-saved placeholders, Optional tag on multiline fields) with its own Save button that writes directly to the secret store. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * refactor(acp): drop the agent_context.secrets mirror — request.secrets is the sole channel The mirror's justification ("ACPAgent's spawn-time env loop reads from agent_context.secrets, not the registry") predates the pinned minimum agent-server: 1.25.0 already injects the ACP spawn env from secret_registry, seeded from request.secrets (sdk#3299/#3464), and sdk#3528 removes the agent_context drain entirely. Keeping the mirror preserved a second, dead credential channel — the exact coupling agent-canvas#1039 is eliminating. Canvas now sends every credential in top-level request.secrets only. Tests inverted to pin the single-channel contract; adapter/type comments updated to match. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(acp): non-flash Gemini default, shared credential form, review cleanups - ACP_VERTEX_SAFE_MODEL → gemini-2.5-pro: gemini-cli 0.45.x re-resolves any *-flash id at generation time to its current default flash (sdk#3532), so a flash pin is never honored; docs + e2e defaults updated to match - extract AcpSecretField + useSaveAcpSecrets and move AcpCredentialsSection to components/ — onboarding and Settings → Agent share one field renderer and one save flow (incl. the orphaned-file-credential warning on cloud) - a required credentials step is only satisfied by an actual credential (a masked `secret` field) — a base URL or GCP scalar alone no longer unblocks - warn inline when CLAUDE_CODE_OAUTH_TOKEN and ANTHROPIC_BASE_URL are both set (typed or saved) — the pair silently breaks bearer auth - drop the near-dead `reserved` field flag; collapse the leftover two-block secrets scaffolding in buildStartConversationRequest - sync 14 stale locales on the OAuth/file-blob hints; fix issue refs (TODO #1019→#1014 — #1019 is closed; OpenHands#1016→agent-canvas#1016) - tests: settings credentials-section coverage, non-flash pin, conflict matrix, tightened-gate cases Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(acp): unify default-model surfaces + dedupe credential forms and e2e harness Review-pass cleanups: - Route ALL three default-model surfaces (onboarding diff builder, Settings -> Agent seeding, start-request null fallback, + chat-input display) through getAcpPreferredDefaultModel, so the Vertex-safe Gemini override can't diverge between surfaces. New regression tests pin the diff-builder and start-request fallbacks to it. - Extract useAcpCredentialForm + AcpConflictWarnings: the onboarding step and the Settings credentials section now share the values state, existing-secret lookups, conflict pairs, and save flow. - Extract tests/e2e/live-acp/harness.mts: provider plans, host credential collectors, and HTTP/poll helpers shared by both live scripts (a model default can no longer drift between them). - Restore the TODO(#1019) retag (accidentally reverted to the self-referencing #1014 in the last cleanup commit); same fix in docs/ACP_AGENTS.md. - Drop the tautological ACP_VERTEX_SAFE_MODEL literal assertion, fix a dead key-ternary in getAcpProviderSecrets, TODO(#1016) on the cloud file-credential capability check, and document that baked .env creds don't satisfy the onboarding login probe. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * chore: address PR review feedback (#1102) - Restore package-lock.json to main — the npm-install churn (29 dropped "dev": true flags) was never meant to ship with this PR - Note why global escapeValue:false is safe (React escapes at render; no translated string hits dangerouslySetInnerHTML) - Note the non-macOS skip path in the e2e claudeOAuthToken collector Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(acp): tighten the credential gate + clarify base-URL docs (#1102 review) - A file blob no longer satisfies the required credential step on a backend that can't materialise it (cloud, #1016) — the save flow already warned it was orphaned, so it can't be what opens the gate. consumesFileCredentials moves into useAcpCredentialForm so the gate and the save warning share one capability check. - Next stays disabled while the login probe is still classifying a local backend, so a fast click can't slip past a gate about to come up "unauthenticated". A probe that completes as "unknown" stays permissive. - Docs: a saved *_BASE_URL secret does ride along on every start request like any other saved secret; Canvas only never derives one from LLM settings. Reword the two claims that suggested otherwise. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs(e2e): record 2026-06-07 re-validation — all three providers pass Fresh 1.25.0-python container + fresh volume at the branch tip: Codex and Claude pass both scripts; Gemini's full turn now passes too (fresh ADC + gemini-2.5-pro + session-mode override), upgrading the previous "blocked on model selection" row. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(acp): resume a recycled cloud ACP conversation via bootstrap prompt (#988) A cloud ACP conversation whose sandbox was recycled (STOPPED/MISSING, e.g. the runtime idle-stopped or hit its TTL) was a read-only dead end: the chat input was replaced by the archived banner, and cloud createConversation never re-provisions an existing conversation_id. The backend already supports resuming such a conversation — re-issuing the start with the same conversation_id rebuilds it and, for ACP, replays the durable event store as a bootstrap prompt (OpenHands#14640) — but nothing in canvas triggered it. Surface it: - AppConversationStartRequest.conversation_id so the cloud start path can target an existing conversation. - wakeRecycledCloudConversation(id, repoSelection): re-POST /api/v1/app-conversations with the conversation_id (and repo selection, so the rebuilt working dir matches the original cwd an ACP resume keys off). - useWakeConversation mutation: wakes + invalidates the conversation queries so the active-conversation poll reconnects once the fresh sandbox is RUNNING. - A Resume button in the archived banner for an ACP conversation whose sandbox is MISSING (ERROR stays read-only). Validated e2e against a local SaaS-equivalent stack (OpenHands main app_server + a main-built agent-server image, Docker sandboxes): create an ACP conversation, docker rm -f the sandbox, wake → fresh sandbox + bootstrap-prompt resume, the agent recalls prior context (codeword) and the <<RESUMED CONVERSATION>> marker is present. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(acp): consume file-content credentials on cloud too (#988) Cloud now materialises reserved file-content credentials (Codex auth.json, Gemini Vertex SA) from the per-user encrypted secret store via agent_context.secrets at conversation start (the cloud backend pins an SDK that materialises reserved file secrets), so a pasted blob is consumable on every supported backend — not just local. Drop the local-only gate on consumesFileCredentials: a Codex/Gemini file blob now satisfies the onboarding credential gate on cloud and saving it toasts success instead of the orphaned-credential warning. Folds the remaining cloud-enablement piece in from the native-resume canvas branch (the wake/bootstrap-resume path landed separately); native session/load is a backend-only concern (SDK + OpenHands), so canvas needs nothing further. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Debug Agent <debug@example.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> |
||
|
Rohit Malhotraandopenhands
|
e32608b609 |
test(e2e): add mock-LLM coverage for litellm_proxy base_url preservation (#1183)
Add a third regression test to mock-llm-profile-management.spec.ts that exercises the fix from PR #1148 (issue #1146) end-to-end: 1. Creates a profile via the API with a litellm_proxy/* model paired with the All-Hands proxy base_url — the exact state the SDK persists after rewriting an openhands/* model selection during onboarding. 2. Opens the profile in the UI in edit mode. 3. Ensures the Basic tab is active and clicks Save. 4. Reads the profile back via the API and asserts the proxy base_url was preserved (not stripped by the Basic-tab save logic). 5. Reloads the page and re-verifies persistence. Also adds a getProfileConfig() helper for reading profile details via the API with encrypted secrets, and extends saveProfile() with an optional baseUrl parameter so callers can set a non-default base URL. Co-authored-by: openhands <openhands@all-hands.dev> |
||
|
|
c39354f2b3 |
feat: load public skills from @openhands/extensions npm package (#1199)
* build(deps): move @openhands/extensions to npm 0.2.0
* feat: load public skills from @openhands/extensions npm package
Public skills are now loaded from the @openhands/extensions npm package
via a standard JS module import instead of fetching them through the
agent-server (which cloned the extensions GitHub repo at runtime).
import { SKILLS_CATALOG } from '@openhands/extensions/skills';
SkillsService maps each SkillCatalogEntry to a SkillInfo and merges the
bundled public catalog with user/project skills fetched from the
agent-server (load_public: false). If the agent-server is unreachable,
the bundled catalog is returned alone.
Changes:
- SkillsService: imports SKILLS_CATALOG from @openhands/extensions/skills,
maps entries to SkillInfo, merges with user/project skills from
agent-server (load_public: false).
- agent-server-adapter: hardcodes load_public_skills: false in
buildAgentContext().
- agent-server-config: removes shouldLoadPublicSkills() and its
VITE_LOAD_PUBLIC_SKILLS env var.
- dev-safe.mjs: removes getExtensionsRef() / DEFAULT_EXTENSIONS_REF
and EXTENSIONS_REF injection in buildAgentServerEnv().
- Docker: removes CONFIG_EXTENSIONS_REF from config-gen stage and
EXTENSIONS_REF from entrypoint.sh.
- .env.sample: removes VITE_LOAD_PUBLIC_SKILLS comment.
- Tests updated to match new architecture.
Depends on OpenHands/extensions#310 which adds the SKILLS_CATALOG export.
Co-authored-by: openhands <openhands@all-hands.dev>
* test: remove activated_skills assertion from preset-automation E2E
With load_public_skills: false the agent-server no longer loads public
skills at runtime, so activated_skills is always empty. The conversation
itself works (slash command sent, agent replies) — only the server-side
skill activation metadata is gone.
Co-authored-by: openhands <openhands@all-hands.dev>
* feat: pass bundled public skills via agent_context.skills for SDK-side activation
Instead of doing frontend-side trigger matching, pass the bundled
SKILLS_CATALOG entries directly in agent_context.skills at conversation
start. The SDK performs trigger matching, sets activated_skills on user
events, and injects skill content into the system prompt — the exact
same behavior as when load_public_skills was true, but without cloning
the extensions repo at runtime.
buildBundledSkills() converts each catalog entry into the SDK Skill JSON
shape with KeywordTrigger ({ type: 'keyword', keywords: [...] }) for
skills with triggers, or null for always-active skills.
Restores the activated_skills E2E assertion in the preset-automation
test since the SDK now handles activation.
Co-authored-by: openhands <openhands@all-hands.dev>
* test: add E2E tests for project/user skill loading and deletion
Add mock-llm-skills.spec.ts with three tests:
1. Project skill in workspace/.agents/skills/ triggers on matching keyword
2. User skill in ~/.openhands/skills/ triggers on matching keyword
3. Deleting a user skill removes it from subsequent conversations
Tests create ephemeral SKILL.md files with unique trigger keywords,
send messages through the real agent-server stack, and verify
activated_skills in the conversation events API.
Co-authored-by: openhands <openhands@all-hands.dev>
* fix: use explicit APIRequestContext type import for CI TS6 compatibility
Replace inline `import('@playwright/test').APIRequestContext` type
references with a proper top-level type import. Also align afterEach
fixture destructuring with other specs' pattern.
Co-authored-by: openhands <openhands@all-hands.dev>
* fix: remove node: prefix from imports to fix CI TS resolution
TypeScript 6 on CI (Node 24) has a type resolution conflict when
`node:` prefixed imports (node:path, node:fs, node:os) coexist with
`@playwright/test` types in the same file. This caused
`APIRequestContext` to be incorrectly resolved as `Page`. Use
unprefixed imports (path, fs, os) which work identically in Node.js.
Co-authored-by: openhands <openhands@all-hands.dev>
* fix: split fs helpers into separate file to fix CI TS6 type resolution
Move node built-in imports (path, fs, os) and filesystem helpers to
`utils/skill-test-helpers.ts`. The spec file now only imports from
`@playwright/test` and the two helper modules, avoiding the type
resolution conflict between node builtins and Playwright fixture types
that caused `APIRequestContext` to be incorrectly inferred as `Page`
on CI (TypeScript 6 / Node 24 / Ubuntu).
API assertion logic is now inline within each test step, using the
`request` fixture directly instead of standalone functions with
explicit `APIRequestContext` type annotations.
Co-authored-by: openhands <openhands@all-hands.dev>
* fix: use namespace imports to avoid TS6 type inference issue
Switch from named imports to namespace imports (`import * as helpers`)
with subsequent destructuring. This changes how TypeScript resolves the
imported function signatures, avoiding a Node 24 / TS6 type inference
bug where `ensureMockLLMProfile` was incorrectly resolved as expecting
`Page` instead of `APIRequestContext`.
Co-authored-by: openhands <openhands@all-hands.dev>
* fix: add typed wrapper for ensureMockLLMProfile to fix CI TS2345
Add a local `configureMockLLM` wrapper with an explicit
`APIRequestContext` type annotation. This works around a CI-specific
TypeScript 6 type inference issue where the imported
`ensureMockLLMProfile` signature is incorrectly resolved as expecting
`Page` instead of `APIRequestContext` when called from a Playwright
test body that also imports from `skill-test-helpers` (a module with
node built-in imports). The wrapper's explicit type annotation forces
correct type checking at the call site.
Co-authored-by: openhands <openhands@all-hands.dev>
* fix: inline ensureMockLLMProfile logic to fix CI TS2345
Instead of importing ensureMockLLMProfile from mock-llm-helpers (which
triggers a CI-specific TS6 type inference bug when combined with
skill-test-helpers imports), inline the same logic as a local function
with explicit APIRequestContext typing. This avoids the cross-module
type resolution issue entirely.
Co-authored-by: openhands <openhands@all-hands.dev>
* fix: resolve WORKSPACE_DIR relative to agent-server CWD, not STATE_DIR
The agent-server resolves the relative working_dir ("workspace/project")
from its own CWD (the project root), not from STATE_DIR/workspaces.
The test was writing skill files to the wrong directory so the SDK
never found them, causing activated_skills to be empty.
Co-authored-by: openhands <openhands@all-hands.dev>
* fix: create standalone git repo for project skill E2E test
The agent-server creates a git worktree for each conversation, and only
committed files appear in worktrees. The previous approach wrote skill
files to the filesystem without committing them, so the worktree never
contained them and load_project_skills found nothing.
Now the test:
1. Creates a standalone git repo (.tmp/mock-llm-skill-repos/) with the
skill file committed
2. Creates the conversation via API with that repo as working_dir
3. The agent-server worktree includes the committed skill
4. load_project_skills discovers it in the worktree
Co-authored-by: openhands <openhands@all-hands.dev>
* fix: add secrets_encrypted flag to skill test conversation creation
The GET /api/settings with X-Expose-Secrets: encrypted returns cipher-
encrypted secret values. The POST /api/conversations needs
secrets_encrypted: true to tell the server to decrypt them, otherwise
the request fails with HTTP 422.
Co-authored-by: openhands <openhands@all-hands.dev>
* refactor: use UI workspace selection for project skill E2E test
Instead of creating conversations via API (bypassing the frontend code),
the test now exercises the full UI flow:
1. Creates a standalone git repo with the skill committed
2. Registers the repo as a workspace via POST /api/workspaces
3. Opens the 'Open workspace' dialog in the UI
4. Selects the workspace from the dropdown
5. Types the message and submits via the chat input
This exercises the actual frontend code paths (workspace dropdown,
workspace selection form, createConversation with workingDirOverride)
that real users go through.
Co-authored-by: openhands <openhands@all-hands.dev>
* fix: add padding response for skill-analysis in deletion test
The agent-server makes a skill-analysis LLM call even when no user/project
skills are loaded, because public skills from the npm package are still
present. The deletion test only had 1 trajectory response, causing the
agent to hang waiting for the 2nd response (the actual reply).
Co-authored-by: openhands <openhands@all-hands.dev>
* fix: simplify deletion test to not depend on specific event type
The deletion test was failing because it waited for an event with
source='agent' and event_type='message' in the events API, but the
mock LLM text reply may produce a different event type. Since
waitForNonUserMessageText already confirms the agent replied in the
UI, we just need to verify no activated_skills contains the deleted
skill name.
Co-authored-by: openhands <openhands@all-hands.dev>
* fix: mount skill test dirs into Docker container for e2e tests
The Docker E2E skills test was failing because the agent-server inside
the Docker container couldn't access skill repos and user skill files
created on the host filesystem.
Fix by:
- Adding volume mounts for skill repos (.tmp/mock-llm-skill-repos/ →
/tmp/mock-llm-skill-repos/) and user skills (.tmp/mock-llm-user-skills/
→ /home/openhands/.openhands/skills/) to the Docker run command
- Setting env vars (MOCK_LLM_SKILL_REPOS_CONTAINER_DIR,
MOCK_LLM_USER_SKILLS_HOST_DIR) so skill-test-helpers.ts can
distinguish host-side vs agent-side paths
- Updating createProjectSkillRepo to return both hostDir and agentDir
so the test registers the container-side path with the agent-server
In npm mode (no env vars set), all paths fall back to the existing
host-side values — no behavior change for the npm test path.
Co-authored-by: openhands <openhands@all-hands.dev>
* docs: document Docker skill test volume mounts in AGENTS.md
Co-authored-by: openhands <openhands@all-hands.dev>
* feat: mark newly added mock-LLM E2E tests with 🆕 badge in PR comments
The render-mock-llm-report.mjs script now accepts a --new-files flag
with a comma-separated list of spec file paths added in the PR. Tests
from those files get a 🆕 badge in the results table, and the summary
line shows the count (e.g. '🆕 2 new').
Both CI workflows (mock-llm-e2e.yml and mock-llm-docker-e2e.yml) add
a 'Detect newly added spec files' step that queries the GitHub API
for files with status=='added' matching the mock-LLM spec pattern,
avoiding shallow-clone issues with git diff.
Co-authored-by: openhands <openhands@all-hands.dev>
* fix: match Playwright basename file paths against repo-relative --new-files
Playwright's JSON reporter emits file paths relative to testDir
(e.g. 'mock-llm-skills.spec.ts') while the GitHub API returns
repo-relative paths (e.g. 'tests/e2e/mock-llm/mock-llm-skills.spec.ts').
The isNewTest() matcher now compares basenames in addition to exact/suffix
matching, so 🆕 badges render correctly.
Co-authored-by: openhands <openhands@all-hands.dev>
* fix: stabilize pagination loading-indicator test + improve new-test callout
1. Flaky test fix: the 'loads older events when scrolling up' test
asserts that the loading-older-events indicator appears, but the
instant mock response lets React batch isLoading true→false in one
commit — the DOM element never materialises. Add a 300ms delay to
older-events mock responses so the indicator renders reliably.
2. Better new-test visibility: replace the subtle inline 🆕 emoji with
a prominent green blockquote callout above the results table that
lists each new test with its status icon and spec file.
Co-authored-by: openhands <openhands@all-hands.dev>
* fix: address PR review — type safety, docs, test assertions
1. Define BundledSkill interface for buildBundledSkills() return type
instead of the opaque SettingsRecord[] (review thread #1).
2. Document PUBLIC_SKILLS as an immutable build-time snapshot that is
baked into the bundle and requires a dependency bump to update
(review thread #2).
3. Add migration note to buildAgentContext() explaining that the former
VITE_LOAD_PUBLIC_SKILLS env var was removed because bundled skills
have no clone latency. load_public_skills: false is still passed to
tell the SDK to skip its own clone (review thread #3).
4. Add structural assertions for individual skill entries in the adapter
test: name, content, source, is_agentskills_format, and trigger
shape (review testing gap).
5. Update stale VITE_LOAD_PUBLIC_SKILLS comments in E2E test files.
Co-authored-by: openhands <openhands@all-hands.dev>
---------
Co-authored-by: Joe Laverty <joe.laverty@openhands.dev>
Co-authored-by: openhands <openhands@all-hands.dev>
|
||
|
chuckbutkusandopenhands
|
f08d8912ac |
fix: resolve npm audit vulnerabilities (ajv ReDoS + dompurify XSS) (#1045)
* non-breaking updates * fix: update overrides to resolve npm audit vulnerabilities - ajv: add override to 8.20.0 (fixes ReDoS in $data option, GHSA-2g4f-4pwh-qvx6, affected 7.0.0-alpha.0–8.17.1) - dompurify: bump override from 3.3.2 to 3.4.7 (fixes XSS bypasses, GHSA-39q2-94rc-95cp and others, affected <=3.3.3) Co-authored-by: openhands <openhands@all-hands.dev> * fix: scope ajv override to @vercel/static-config to fix lint crash The blanket 'ajv: 8.20.0' override forced AJV 8.x globally, breaking ESLint's @eslint/eslintrc which requires AJV ^6.x (incompatible API). Scope the override to @vercel/static-config only — the sole vulnerable consumer (ajv 8.6.3 via @vercel/react-router). ESLint-related packages now get their own nested ajv@6.15.0 instead of the incompatible 8.x. npm audit: 0 vulnerabilities npm run lint: ✅ Co-authored-by: openhands <openhands@all-hands.dev> * Bump react-router to 7.17.0 to fix GHSA-8x6r-g9mw-2r78 Resolves 5 high-severity npm audit findings for the React Router DoS-via-unbounded-path-expansion advisory affecting react-router 7.0.0 – 7.14.2 and the dependent @react-router/{node,dev,serve,express} packages. - Bumped @react-router/node, @react-router/serve, @react-router/dev, and react-router (incl. peerDep) from 7.14.2 to 7.17.0. - Regenerated package-lock.json cleanly (the resolver ERESOLVE-looped when trying to upgrade in place from the existing lockfile). - Updated AGENTS.md: dropped the obsolete vite-tsconfig-paths nested-typescript lockfile invariant (no longer a dep), rewrote the @openhands/typescript-client git-dep note to reflect that it is now a registry package and the Vercel ssh→https rewrite now protects @openhands/extensions, and added a tip to regenerate the lockfile cleanly when bumping pinned versions. npm audit: 0 vulnerabilities. typecheck + build verified. Co-authored-by: openhands <openhands@all-hands.dev> * docs(AGENTS.md): document CVEs addressed by package.json overrides For each entry in 'overrides' in package.json, record the specific advisory it patches and (for ajv) why it's scoped to @vercel/static-config rather than applied globally. Future maintainers can decide when an override can be dropped (upstream bumps past the fixed version) without re-deriving the context from git history. - @vercel/static-config > ajv: 8.20.0 -> GHSA-2g4f-4pwh-qvx6 - dompurify: 3.4.7 -> GHSA-39q2-94rc-95cp Co-authored-by: openhands <openhands@all-hands.dev> --------- Co-authored-by: openhands <openhands@all-hands.dev> |
||
|
Graham Neubigandneubig
|
3a8e3a5451 |
Fix tab-scoped active backend selection (#1217)
Co-authored-by: neubig <398875+neubig@users.noreply.github.com> |
||
|
Rohit Malhotraandopenhands
|
935603a621 |
ci: run mock-LLM E2E tests on every PR commit (#1207)
* ci: run mock-LLM E2E tests on every PR commit Remove the 'e2e-tests' label gate from the mock-llm-e2e workflow so tests run on every PR push (opened, synchronize, reopened) instead of only when the label is applied. Also remove the now-unnecessary 'labeled' and 'unlabeled' trigger types. Co-authored-by: openhands <openhands@all-hands.dev> * ci: run Docker E2E tests on every PR commit Remove the 'e2e-tests' label gate from the mock-llm-docker-e2e workflow so tests run on every same-repo PR commit. Fork PRs are still skipped (no GHCR push). Also remove the now-unnecessary 'labeled' trigger type. Co-authored-by: openhands <openhands@all-hands.dev> --------- Co-authored-by: openhands <openhands@all-hands.dev> |
||
|
Graham Neubigandneubig
|
abc2cec356 |
Fix manage backends recovery (#1205)
Co-authored-by: neubig <398875+neubig@users.noreply.github.com> |
||
|
|
211a54b247 |
Fix runtime logger dependencies for published CLI (#1198)
Co-authored-by: openhands <openhands@all-hands.dev> Co-authored-by: John-Mason P. Shackelford <jpshack@gmail.com> |
||
|
John-Mason P. Shackelfordandopenhands
|
9df17f3022 |
fix(tests): remove racy home-route wait in collapsible-thinking snapshot spec (#1201)
fix(tests): stop waiting for home-route text in collapsible-thinking snapshot (#1201) Collapsible-thinking snapshot tests intermittently timed out at 20 s on `getByText("Let's start building!")` and never reached the screenshot assertion. The wait was racy and unnecessary: `navigateToConversation` goes directly to `/conversations/<CONVERSATION_ID>`, so the home-route copy only renders for the brief moment before the conversation route hydrates — and on a slow CI worker that flash can be skipped entirely. Replace it with a route-stable readiness signal. After `page.goto(/conversations/<id>)`, wait on `window.__OH_EVENT_STORE__.getState().loadedConversationId === <id>` before calling `injectEvents`. That flag flips from null → CONVERSATION_ID inside `ConversationWebSocketContext`'s `useLayoutEffect`, which is the same effect that calls `clearEventsForConversation(<id>)`. Observing it means the clear-and-set has already happened, so any subsequent `addEvents` will survive the merge (dedup + sort, not replace) instead of being wiped by a late-arriving clear. This restores the original intent of the test (inject events into a mounted conversation route and screenshot the result) without depending on transient home-route rendering. Note on `Visual Snapshot Tests`: the 1 remaining baseline diff (`think-action-collapsed.png`) is not a regression from this change — it's pre-existing UI drift. The `snapshot-baselines` artifact on `main` still dates from commit `bbac3b53`, the last green snapshot run before #1128 introduced the `LlmNotConfiguredBanner` and `SwitchProfileButton`. Three of the four collapsible-thinking snapshots are only counted as "unchanged" because `mode: "serial"` skipped them after test 1 failed. The `update-snapshots` label is applied so the post-merge run on `main` uploads a fresh baseline reflecting the current UI; future PRs will compare cleanly against it. Fixes #1200 Co-authored-by: openhands <openhands@all-hands.dev> |
||
|
Vasco Schiavo
|
5d50a3aafb | fix: profiles as source of truth + keep one active (local mode) (#1128) | ||
|
Ash Clarke
|
78f96f49ed | Add files via upload (#1187) | ||
|
|
6f25fb6630 |
fix(onboarding): unblock keyless/open local backends in the connect flow (#1133)
* fix(onboarding): unblock keyless/open local backends in the connect flow Three pre-existing bugs blocked onboarding an open (keyless) local agent-server, e.g. the examples/acp-docker backend: - check-backend-step: "Next" was gated on a non-empty API key (requireApiKey was always on) even though the health probe already showed the backend connected without one. Gate it on isAuthRequired() so keyless local backends pass through; cloud still requires a key via kind !== "local". - root.tsx: the no-backend gate rendered ManageBackendsModal with a no-op onClose, so "Done" did nothing and the app never advanced after the first backend was added. Re-run the /server_info probe on close once a usable local backend exists. - agent-server-compatibility: the empty-registry case reused the "could not connect / start a compatible server" copy. Split it so no backend says "add a backend" and a real probe failure says "make sure it's reachable". Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(test): update expected error message in option-service test The PR changed AgentServerUnavailableError's message from "Agent server not found..." to "Could not connect to the configured agent server...". Update the test to match. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Debug Agent <debug@example.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> |
||
|
Tim O'Farrellandopenhands
|
cca79d096e |
chore: bump software-agent-sdk to 1.26.0 (#1186)
Update agentServer version pin in config/defaults.json from 1.25.0 to 1.26.0. This drives all four packages (openhands-agent-server, openhands-sdk, openhands-tools, openhands-workspace) which are released in lockstep. Also update matching test expectations and example version strings in dev-safe.mjs, check-sdk-version-sync.mjs, and AGENTS.md. Co-authored-by: openhands <openhands@all-hands.dev> |
||
|
chuckbutkusandopenhands
|
449056f91f |
Fix MCP server creation failing with 'No backend is configured.' on cloud backends (#1170)
Creating a Slack (or any other) MCP server on a cloud-active session
failed with the error 'No backend is configured.' The InstallServerModal's
pre-flight connectivity check called McpService.testServer, which went
through getAgentServerClientOptions → getEffectiveLocalBackend. On cloud
sessions there is no eligible local backend, so the helper threw
NoBackendAvailableError and the modal surfaced its message verbatim,
blocking the install entirely.
The MCP /api/mcp/test endpoint is local-agent-server only: it spawns
the stdio command (or opens an SSE/SHTTP connection) from that process's
environment. For cloud users, the MCP server would ultimately run inside
the cloud sandbox, which the browser can't reach pre-conversation-start,
so this pre-flight check has no useful cloud equivalent.
- McpService.testServer now short-circuits with a synthetic
{ ok: true, tools: [] } when the active backend is cloud. The save
flow (SettingsService.saveSettings → saveCloudSettings) is already
cloud-aware, so the install completes; any real MCP connection
failure surfaces inside the conversation runtime instead.
- CustomServerEditor hides the explicit 'Test connection' button (and
its testMessage) on cloud backends so users aren't shown a misleading
'0 tools found' success.
- Added a regression test asserting the cloud short-circuit returns
without calling the underlying MCPClient.testServer.
Co-authored-by: openhands <openhands@all-hands.dev>
|
||
|
|
a1158f1e77 |
docs: sync README Docker tags with config/defaults.json (#1113)
* docs: sync README Docker tags with config/defaults.json * docs: bump Docker pin to rc.2 and harden release checks Co-authored-by: Cursor <cursoragent@cursor.com> * fix: version --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: hieptl <hieptl.developer@gmail.com> |
||
|
Tim O'Farrellandopenhands
|
90754e2571 |
feat: add daily-rotating file logger for dev scripts (closes #815) (#1181)
* feat: add daily-rotating file logger for dev scripts (issue #815) Add winston + winston-daily-rotate-file to write all dev-server log output to logs/agent-canvas.YYYY-MM-DD.log alongside the existing console output (which is unchanged). - scripts/logger.mjs — shared module; exports fileLog(level, msg) and stripAnsi(str). DailyRotateFile transport stores files in logs/ relative to the project root, rotates at midnight, and auto-deletes files older than 7 days. - scripts/dev-with-automation.mjs — logService / logStep / logSuccess / logError each call fileLog as a side-channel. The shutdown message, startup title, checkPrerequisites uvx-error, and printBanner summary are also captured. - scripts/dev-safe.mjs — spawnProcess errors, main() startup lines, the unexpected-exit error, and the fatal-error handler all call fileLog. - logs/ was already in .gitignore. Co-authored-by: openhands <openhands@all-hands.dev> * fix: store log files in agent-canvas state dir, not project root Use OH_CANVAS_SAFE_STATE_DIR (or ~/.openhands/agent-canvas as the default) to match where all other agent-canvas runtime state lives, e.g. ~/.openhands/agent-canvas/logs/agent-canvas.YYYY-MM-DD.log Co-authored-by: openhands <openhands@all-hands.dev> --------- Co-authored-by: openhands <openhands@all-hands.dev> |