github/OpenHands
1
0
Fork 0
mirror of https://github.com/OpenHands/OpenHands.git synced 2025-12-26 05:48:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(agent controller): missing await (#6040)

Browse Source
This commit is contained in:
Xingyao Wang 2025-01-04 23:57:07 -05:00 committed by GitHub
parent d2790c8b21
commit b7bbf0f5eb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
openhands/controller/agent_controller.py
View File

@ -390,7 +390,7 @@ class AgentController:
if new_state in (AgentState.STOPPED, AgentState.ERROR):
# sync existing metrics BEFORE resetting the agent
self.update_state_after_step()
await self.update_state_after_step()
self.state.metrics.merge(self.state.local_metrics)
self._reset()
elif (

13
tests/unit/test_agent_controller.py
View File

@ -39,11 +39,7 @@ def event_loop():
def mock_agent():
agent = MagicMock(spec=Agent)
agent.llm = MagicMock(spec=LLM)
metrics = MagicMock(spec=Metrics)
metrics.costs = []
metrics.accumulated_cost = 0.0
metrics.response_latencies = []
agent.llm.metrics = metrics
agent.llm.metrics = Metrics()
return agent
@ -297,13 +293,6 @@ async def test_max_iterations_extension(mock_agent, mock_event_stream):
# Test with headless_mode=False - should extend max_iterations
initial_state = State(max_iterations=10)
# Set up proper metrics mock with required attributes
metrics = MagicMock(spec=Metrics)
metrics._costs = []
metrics._response_latencies = []
metrics.accumulated_cost = 0.0
mock_agent.llm.metrics = metrics
controller = AgentController(
agent=mock_agent,
event_stream=mock_event_stream,