github/OpenHands
1
0
Fork 0
mirror of https://github.com/OpenHands/OpenHands.git synced 2026-03-22 05:37:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix up settings saves (#4037)

Browse Source
This commit is contained in:
Robert Brennan
2024-09-24 14:18:19 -04:00
committed by GitHub
parent 2f1b537471
commit 7b2b1eff57
3 changed files with 5 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
frontend/src/components/modals/settings/SettingsForm.tsx
View File

@@ -54,8 +54,6 @@ function SettingsForm({
const handleAdvancedChange = (value: boolean) => {
setEnableAdvanced(value);
// Reset the base URL if the user disables advanced options
if (!value) onBaseURLChange("");
};
return (

8
frontend/src/services/settings.ts
View File

@@ -87,10 +87,10 @@ export const getSettings = (): Settings => {
export const saveSettings = (settings: Partial<Settings>) => {
Object.keys(settings).forEach((key) => {
const isValid = validKeys.includes(key as keyof Settings);
const value = settings[key as keyof Settings];
if (isValid && typeof value !== "undefined")
localStorage.setItem(key, value.toString());
if (!isValid) return;
let value = settings[key as keyof Settings];
if (value === undefined || value === null) value = "";
localStorage.setItem(key, value.toString());
});
localStorage.setItem("SETTINGS_VERSION", LATEST_SETTINGS_VERSION.toString());
};

4
openhands/server/session/session.py
View File

@@ -76,9 +76,7 @@ class Session:
AgentStateChangedObservation('', AgentState.LOADING), EventSource.AGENT
)
# Extract the agent-relevant arguments from the request
args = {
key: value for key, value in data.get('args', {}).items() if value != ''
}
args = {key: value for key, value in data.get('args', {}).items()}
agent_cls = args.get(ConfigType.AGENT, self.config.default_agent)
self.config.security.confirmation_mode = args.get(
ConfigType.CONFIRMATION_MODE, self.config.security.confirmation_mode