mirror of
https://github.com/OpenHands/OpenHands.git
synced 2026-10-07 15:58:03 +08:00
revert(onboarding): restore OpenAI GPT-5.5 as onboarding LLM default
Undo the change from #16531, which switched the first-run onboarding LLM default from OpenAI GPT-5.5 to the OpenHands provider. Restores the OpenAI/GPT-5.5 default constant, the localized subtitle copy, and the unit/e2e tests to their pre-#16531 behavior. Note: this is a fresh reverse-change rather than a git revert, since the onboarding default constant has since drifted (#16657 changed it to openhands/kimi-k3); the kimi-k3 mock entry is left intact. Co-authored-by: openhands <openhands@all-hands.dev>
This commit is contained in:
@@ -649,7 +649,7 @@ describe("OnboardingModal", () => {
|
||||
);
|
||||
});
|
||||
|
||||
it("pre-fills the LLM step with the OpenHands default model", () => {
|
||||
it("pre-fills the LLM step with OpenAI GPT-5.5", () => {
|
||||
renderModal();
|
||||
|
||||
expect(llmSettingsScreenMock).toHaveBeenCalledTimes(1);
|
||||
|
||||
@@ -16,16 +16,13 @@ interface SetupLlmStepProps {
|
||||
}
|
||||
|
||||
/**
|
||||
* Pre-fills the LLM form with the OpenHands provider's free default model
|
||||
* (`openhands/kimi-k3`), matching `DEFAULT_SETTINGS.llm_model`. The OpenHands
|
||||
* provider is the agent the user just selected, so the onboarding override
|
||||
* keeps the LLM provider aligned with that choice rather than silently
|
||||
* switching to OpenAI. Canvas stores provider-qualified LiteLLM model ids,
|
||||
* so the override uses this OpenHands-prefixed model id, and keeping it as an
|
||||
* explicit override marks the model dirty so the Next button persists the
|
||||
* suggested default immediately.
|
||||
* Pre-fills the LLM form with the OpenAI GPT-5.5 model. The SDK's
|
||||
* bare default model is `gpt-5.5`; Canvas stores provider-qualified
|
||||
* LiteLLM model ids, so the onboarding override uses this OpenAI-prefixed
|
||||
* model id. Keeping this as an explicit override marks the model dirty so
|
||||
* the Next button persists the suggested default immediately.
|
||||
*/
|
||||
export const ONBOARDING_DEFAULT_LLM_MODEL = "openhands/kimi-k3";
|
||||
export const ONBOARDING_DEFAULT_LLM_MODEL = "openai/gpt-5.5";
|
||||
|
||||
/**
|
||||
* Step 2: embed the LLM settings form. The screen runs in `embedded`
|
||||
@@ -42,7 +39,7 @@ export const ONBOARDING_DEFAULT_LLM_MODEL = "openhands/kimi-k3";
|
||||
* Note: returning Cloud users who already have an LLM configured are
|
||||
* intercepted upstream by `OnboardingHost`, so they never reach this
|
||||
* step. Users who do reach it are first-time installs (Cloud or Local)
|
||||
* who want the OpenHands default pre-filled.
|
||||
* who want the OpenAI/GPT-5.5 default pre-filled.
|
||||
*/
|
||||
export function SetupLlmStep({ onBack, onNext }: SetupLlmStepProps) {
|
||||
const { t } = useTranslation("openhands");
|
||||
|
||||
+15
-15
@@ -30787,21 +30787,21 @@
|
||||
"uk": "Налаштуйте свій LLM"
|
||||
},
|
||||
"ONBOARDING$LLM_SUBTITLE": {
|
||||
"en": "Pick a provider and model. We've pre-selected OpenHands GLM-5.2.",
|
||||
"ja": "プロバイダーとモデルを選択してください。OpenHands GLM-5.2 を事前に選択しています。",
|
||||
"zh-CN": "选择提供商和模型。我们已为你预先选择 OpenHands GLM-5.2。",
|
||||
"zh-TW": "選擇供應商與模型。我們已預先選好 OpenHands GLM-5.2。",
|
||||
"ko-KR": "공급자와 모델을 선택하세요. 기본값으로 OpenHands GLM-5.2가 선택되어 있습니다.",
|
||||
"no": "Velg en leverandør og modell. Vi har forhåndsvalgt OpenHands GLM-5.2.",
|
||||
"ar": "اختر مزوّدًا ونموذجًا. لقد اخترنا مسبقًا OpenHands GLM-5.2.",
|
||||
"de": "Wählen Sie Anbieter und Modell. Wir haben OpenHands GLM-5.2 vorausgewählt.",
|
||||
"fr": "Choisissez un fournisseur et un modèle. Nous avons présélectionné OpenHands GLM-5.2.",
|
||||
"it": "Scegli un provider e un modello. Abbiamo preselezionato OpenHands GLM-5.2.",
|
||||
"pt": "Escolha um provedor e modelo. Já selecionamos o OpenHands GLM-5.2.",
|
||||
"es": "Elige un proveedor y modelo. Hemos preseleccionado OpenHands GLM-5.2.",
|
||||
"ca": "Trieu un proveïdor i model. Hem preseleccionat OpenHands GLM-5.2.",
|
||||
"tr": "Bir sağlayıcı ve model seçin. OpenHands GLM-5.2'i önceden seçtik.",
|
||||
"uk": "Виберіть провайдера та модель. OpenHands GLM-5.2 уже обрано."
|
||||
"en": "Pick a provider and model. We've pre-selected OpenAI GPT-5.5.",
|
||||
"ja": "プロバイダーとモデルを選択してください。OpenAI GPT-5.5 を事前に選択しています。",
|
||||
"zh-CN": "选择提供商和模型。我们已为你预先选择 OpenAI GPT-5.5。",
|
||||
"zh-TW": "選擇供應商與模型。我們已預先選好 OpenAI GPT-5.5。",
|
||||
"ko-KR": "공급자와 모델을 선택하세요. 기본값으로 OpenAI GPT-5.5가 선택되어 있습니다.",
|
||||
"no": "Velg en leverandør og modell. Vi har forhåndsvalgt OpenAI GPT-5.5.",
|
||||
"ar": "اختر مزوّدًا ونموذجًا. لقد اخترنا مسبقًا OpenAI GPT-5.5.",
|
||||
"de": "Wählen Sie Anbieter und Modell. Wir haben OpenAI GPT-5.5 vorausgewählt.",
|
||||
"fr": "Choisissez un fournisseur et un modèle. Nous avons présélectionné OpenAI GPT-5.5.",
|
||||
"it": "Scegli un provider e un modello. Abbiamo preselezionato OpenAI GPT-5.5.",
|
||||
"pt": "Escolha um provedor e modelo. Já selecionamos o OpenAI GPT-5.5.",
|
||||
"es": "Elige un proveedor y modelo. Hemos preseleccionado OpenAI GPT-5.5.",
|
||||
"ca": "Trieu un proveïdor i model. Hem preseleccionat OpenAI GPT-5.5.",
|
||||
"tr": "Bir sağlayıcı ve model seçin. OpenAI GPT-5.5'i önceden seçtik.",
|
||||
"uk": "Виберіть провайдера та модель. OpenAI GPT-5.5 уже обрано."
|
||||
},
|
||||
"ONBOARDING$HELLO_TITLE": {
|
||||
"en": "Say hello 👋",
|
||||
|
||||
@@ -61,10 +61,11 @@ test.describe("onboarding recent regressions", () => {
|
||||
});
|
||||
|
||||
// Regression coverage for #1077 / PR #1089: first-run LLM setup
|
||||
// should default users to the OpenHands provider, matching the agent
|
||||
// selected on the previous step.
|
||||
// should not default users to the OpenHands provider.
|
||||
|
||||
test("defaults the LLM setup step to OpenHands GLM-5.2", async ({ page }) => {
|
||||
test("defaults the LLM setup step to OpenAI GPT-5.5", async ({
|
||||
page,
|
||||
}) => {
|
||||
await showOnboarding(page, {
|
||||
apiKey: SESSION_API_KEY,
|
||||
beforeGoto: async () => {
|
||||
@@ -94,18 +95,18 @@ test.describe("onboarding recent regressions", () => {
|
||||
|
||||
await expect(
|
||||
providerInput,
|
||||
"first-run onboarding should default to the OpenHands provider",
|
||||
).toHaveValue("OpenHands", { timeout: 10_000 });
|
||||
"first-run onboarding should default to the OpenAI provider",
|
||||
).toHaveValue("OpenAI", { timeout: 10_000 });
|
||||
// The model input displays the model ID without the provider prefix.
|
||||
await expect(
|
||||
modelInput,
|
||||
"first-run onboarding should default to Kimi K3",
|
||||
).toHaveValue("kimi-k3", {
|
||||
"first-run onboarding should default to GPT-5.5",
|
||||
).toHaveValue("gpt-5.5", {
|
||||
timeout: 10_000,
|
||||
});
|
||||
await expect(
|
||||
page.getByTestId("openhands-account-help"),
|
||||
"OpenHands account helper should be visible for OpenHands defaults",
|
||||
).toBeVisible();
|
||||
"OpenHands account helper should stay hidden for OpenAI defaults",
|
||||
).toHaveCount(0);
|
||||
});
|
||||
});
|
||||
|
||||
@@ -21,7 +21,7 @@ export async function routeOnboardingLlmCatalog(page: Page) {
|
||||
models: {
|
||||
anthropic: ["claude-opus-4-8"],
|
||||
openai: ["gpt-5.5"],
|
||||
openhands: ["claude-opus-4-5-20251101", "kimi-k3", "glm-5.2"],
|
||||
openhands: ["claude-opus-4-5-20251101", "kimi-k3"],
|
||||
},
|
||||
}),
|
||||
});
|
||||
@@ -37,7 +37,6 @@ export async function routeOnboardingLlmCatalog(page: Page) {
|
||||
"openai/gpt-5.5",
|
||||
"openhands/claude-opus-4-5-20251101",
|
||||
"openhands/kimi-k3",
|
||||
"openhands/glm-5.2",
|
||||
],
|
||||
}),
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user