gitee/yudao-boot-mini
1
0
Fork 0
mirror of https://gitee.com/yudaocode/yudao-boot-mini.git synced 2026-10-06 06:12:58 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #1234 from dadiyang/fix/product-sku-empty-properties

Browse Source 
[ENHANCE]
This commit is contained in:
芋道源码
2026-09-26 10:42:05 +08:00
committed by GitHub
parent 9b5241dd7f a83a9e0429
commit 330fa3a297
2 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
yudao-module-mall/yudao-module-product/src/main/java/cn/iocoder/yudao/module/product/enums/ErrorCodeConstants.java
+1
View File
@@ -45,6 +45,7 @@ public interface ErrorCodeConstants {
ErrorCode SPU_ATTR_NUMBERS_MUST_BE_EQUALS = new ErrorCode(1_008_006_002, "一个 SPU 下的每个 SKU，其属性项必须一致");
ErrorCode SPU_SKU_NOT_DUPLICATE = new ErrorCode(1_008_006_003, "一个 SPU 下的每个 SKU，必须不重复");
ErrorCode SKU_STOCK_NOT_ENOUGH = new ErrorCode(1_008_006_004, "商品 SKU 库存不足");
ErrorCode SKU_PROPERTIES_EMPTY = new ErrorCode(1_008_006_005, "多规格商品必须从规格列表选择属性组合，SKU 属性不能为空");
// ========== 商品 评价 1-008-007-000 ==========
ErrorCode COMMENT_NOT_EXISTS = new ErrorCode(1_008_007_000, "商品评价不存在");
yudao-module-mall/yudao-module-product/src/main/java/cn/iocoder/yudao/module/product/service/sku/ProductSkuServiceImpl.java
+7 -3
View File
@@ -106,9 +106,13 @@ public class ProductSkuServiceImpl implements ProductSkuService {
Set<Long> propertyIds = skus.stream().filter(p -> p.getProperties() != null)
// 遍历多个 Property 属性
.flatMap(p -> p.getProperties().stream())
// 将每个 Property 转换成对应的 propertyId，最后形成集合
.map(ProductSkuSaveReqVO.Property::getPropertyId)
.collect(Collectors.toSet());
// 将每个 Property 转换成对应的 propertyId，最后形成集合
.map(ProductSkuSaveReqVO.Property::getPropertyId)
.collect(Collectors.toSet());
// 多规格下，属性组合不能为空：空集合会让后续按 id 批量查询生成非法 SQL（IN()）而 500，这里明确拒绝
if (CollUtil.isEmpty(propertyIds)) {
throw exception(SKU_PROPERTIES_EMPTY);
}
List<ProductPropertyDO> propertyList = productPropertyService.getPropertyList(propertyIds);
if (propertyList.size() != propertyIds.size()) {
throw exception(PROPERTY_NOT_EXISTS);