mirror of
https://github.com/ZhuLinsen/daily_stock_analysis.git
synced 2026-10-06 15:13:28 +08:00
LouisHong
65e28e1faa
* fix: accept HK autocomplete codes on home analysis input The home page stock input accepted plain A-share codes but rejected Hong Kong stocks selected from autocomplete. The root cause was that autocomplete submits the suggestion canonicalCode (for example 00700.HK), while the backend stock code utility only recognized .SH/.SZ/.SS suffixes. As a result, 00700.HK was treated as mixed alphanumeric noise and rejected with the generic validation error before analysis dispatch. Extend shared stock code recognition and normalization to accept .HK suffixes alongside existing A-share suffixes. This keeps the existing manual input behavior for 00700 and makes the backend consistent with the canonicalCode format already used by the web stock index and autocomplete flow. Add regression coverage on both sides of the boundary: backend contract tests now verify that trigger_analysis accepts 00700.HK from autocomplete and HK00700 from manual input, and frontend tests now verify that highlighted HK suggestions submit the canonical .HK code and are not rejected by local store validation. * update CHANGELOG.md * fix: align HK code validation with existing market rules Follow up the home page HK autocomplete fix by tightening the shared stock code validator so exchange suffixes and prefixes no longer reuse the same generic 5-6 digit rule. This change keeps SH/SZ/SS suffixes restricted to 6-digit mainland codes, treats HK suffixes and HK prefixes as 1-5 digit Hong Kong codes with zero-padding during normalization, and rejects invalid cross-market combinations such as 600519.HK, HK600519, and 00700.SH. Add regression coverage for valid short HK forms like 1810.HK and HK700, plus negative tests for invalid suffix and prefix lengths, so the shared backend utility stays consistent with the existing web validation and data-provider normalization rules.
161 lines
4.6 KiB
Python
161 lines
4.6 KiB
Python
# -*- coding: utf-8 -*-
|
|
"""
|
|
Tests for src/services/stock_code_utils.py
|
|
Covers: is_code_like, normalize_code - including exchange prefix handling.
|
|
"""
|
|
|
|
import pytest
|
|
|
|
from src.services.stock_code_utils import is_code_like, normalize_code
|
|
|
|
|
|
class TestIsCodeLike:
|
|
# --- Plain digit codes ---
|
|
def test_plain_6_digit(self):
|
|
assert is_code_like("600519") is True
|
|
|
|
def test_plain_5_digit(self):
|
|
assert is_code_like("00700") is True
|
|
|
|
def test_4_digit_rejected(self):
|
|
assert is_code_like("6001") is False
|
|
|
|
# --- Suffix format ---
|
|
def test_suffix_sh(self):
|
|
assert is_code_like("600519.SH") is True
|
|
|
|
def test_suffix_sz(self):
|
|
assert is_code_like("000001.SZ") is True
|
|
|
|
def test_suffix_lowercase(self):
|
|
assert is_code_like("600519.sh") is True
|
|
|
|
# --- HK suffix format ---
|
|
def test_suffix_hk(self):
|
|
assert is_code_like("00700.HK") is True
|
|
|
|
def test_suffix_hk_lowercase(self):
|
|
assert is_code_like("00700.hk") is True
|
|
|
|
def test_suffix_hk_short_code(self):
|
|
assert is_code_like("1810.HK") is True
|
|
|
|
def test_suffix_hk_rejects_6_digit_base(self):
|
|
assert is_code_like("600519.HK") is False
|
|
|
|
def test_suffix_sh_rejects_5_digit_base(self):
|
|
assert is_code_like("00700.SH") is False
|
|
|
|
# --- Exchange prefix format (Issue #6 fix) ---
|
|
def test_prefix_sh_upper(self):
|
|
assert is_code_like("SH600519") is True
|
|
|
|
def test_prefix_sh_lower(self):
|
|
assert is_code_like("sh600519") is True
|
|
|
|
def test_prefix_sz(self):
|
|
assert is_code_like("SZ000001") is True
|
|
|
|
def test_prefix_hk(self):
|
|
assert is_code_like("HK00700") is True
|
|
|
|
def test_prefix_hk_lower(self):
|
|
assert is_code_like("hk00700") is True
|
|
|
|
def test_prefix_hk_short_code(self):
|
|
assert is_code_like("HK700") is True
|
|
|
|
def test_prefix_hk_rejects_6_digit_base(self):
|
|
assert is_code_like("HK600519") is False
|
|
|
|
# --- US tickers ---
|
|
def test_us_ticker(self):
|
|
assert is_code_like("AAPL") is True
|
|
|
|
def test_us_ticker_with_exchange(self):
|
|
assert is_code_like("TSLA.O") is True
|
|
|
|
# --- Negative cases ---
|
|
def test_plain_text(self):
|
|
assert is_code_like("贵州茅台") is False
|
|
|
|
def test_empty(self):
|
|
assert is_code_like("") is False
|
|
|
|
def test_mixed_invalid(self):
|
|
assert is_code_like("abc123") is False
|
|
|
|
|
|
class TestNormalizeCode:
|
|
# --- Plain digit codes ---
|
|
def test_plain_6_digit(self):
|
|
assert normalize_code("600519") == "600519"
|
|
|
|
def test_plain_5_digit(self):
|
|
assert normalize_code("00700") == "00700"
|
|
|
|
def test_whitespace_stripped(self):
|
|
assert normalize_code(" 600519 ") == "600519"
|
|
|
|
# --- Suffix format ---
|
|
def test_suffix_sh_strips(self):
|
|
assert normalize_code("600519.SH") == "600519"
|
|
|
|
def test_suffix_sz_strips(self):
|
|
assert normalize_code("000001.SZ") == "000001"
|
|
|
|
def test_suffix_ss_strips(self):
|
|
assert normalize_code("600000.SS") == "600000"
|
|
|
|
def test_suffix_hk_strips(self):
|
|
assert normalize_code("00700.HK") == "00700"
|
|
|
|
def test_suffix_hk_lowercase_strips(self):
|
|
assert normalize_code("00700.hk") == "00700"
|
|
|
|
def test_suffix_hk_short_code_is_zero_padded(self):
|
|
assert normalize_code("1810.HK") == "01810"
|
|
|
|
def test_suffix_hk_rejects_6_digit_base(self):
|
|
assert normalize_code("600519.HK") is None
|
|
|
|
def test_suffix_sh_rejects_5_digit_base(self):
|
|
assert normalize_code("00700.SH") is None
|
|
|
|
# --- Exchange prefix format (Issue #6 fix) ---
|
|
def test_prefix_sh_upper(self):
|
|
assert normalize_code("SH600519") == "600519"
|
|
|
|
def test_prefix_sh_lower(self):
|
|
assert normalize_code("sh600519") == "600519"
|
|
|
|
def test_prefix_sz(self):
|
|
assert normalize_code("SZ000001") == "000001"
|
|
|
|
def test_prefix_hk(self):
|
|
assert normalize_code("HK00700") == "00700"
|
|
|
|
def test_prefix_hk_lower(self):
|
|
assert normalize_code("hk00700") == "00700"
|
|
|
|
def test_prefix_hk_short_code_is_zero_padded(self):
|
|
assert normalize_code("HK700") == "00700"
|
|
|
|
def test_prefix_hk_rejects_6_digit_base(self):
|
|
assert normalize_code("HK600519") is None
|
|
|
|
# --- US tickers ---
|
|
def test_us_ticker(self):
|
|
assert normalize_code("AAPL") == "AAPL"
|
|
|
|
# --- Invalid inputs ---
|
|
def test_empty_returns_none(self):
|
|
assert normalize_code("") is None
|
|
|
|
def test_plain_text_returns_none(self):
|
|
assert normalize_code("贵州茅台") is None
|
|
|
|
def test_partial_prefix_no_digits_returns_none(self):
|
|
# SH followed by wrong digit count
|
|
assert normalize_code("SH6005") is None
|