mirror of
https://github.com/awesome-skills/code-review-skill.git
synced 2026-03-22 10:28:31 +08:00
feat: 在审查流程中添加架构/性能审查触发点
- Phase 2 添加 Architecture Review Guide 引用 - 新增 Performance Assessment 检查项 - 明确列出关键检查点(SOLID、N+1、复杂度等)
This commit is contained in:
9
SKILL.md
9
SKILL.md
@@ -102,8 +102,13 @@ Before diving into code, understand:
|
|||||||
### Phase 2: High-Level Review (5-10 minutes)
|
### Phase 2: High-Level Review (5-10 minutes)
|
||||||
|
|
||||||
1. **Architecture & Design** - Does the solution fit the problem?
|
1. **Architecture & Design** - Does the solution fit the problem?
|
||||||
2. **File Organization** - Are new files in the right places?
|
- For significant changes, consult [Architecture Review Guide](reference/architecture-review-guide.md)
|
||||||
3. **Testing Strategy** - Are there tests covering edge cases?
|
- Check: SOLID principles, coupling/cohesion, anti-patterns
|
||||||
|
2. **Performance Assessment** - Are there performance concerns?
|
||||||
|
- For performance-critical code, consult [Performance Review Guide](reference/performance-review-guide.md)
|
||||||
|
- Check: Algorithm complexity, N+1 queries, memory usage
|
||||||
|
3. **File Organization** - Are new files in the right places?
|
||||||
|
4. **Testing Strategy** - Are there tests covering edge cases?
|
||||||
|
|
||||||
### Phase 3: Line-by-Line Review (10-20 minutes)
|
### Phase 3: Line-by-Line Review (10-20 minutes)
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user