Graham Neubigandopenhands c8959713b2 Translate hardcoded settings strings (#134, ports OpenHands#14286) (#143) ...

Ports the i18n half of upstream OpenHands frontend PR #14286
('fix(i18n): translate hardcoded settings strings'):

  - app-settings.tsx: replaced the hardcoded
    placeholder='Username for git commits' and
    placeholder='Email for git commits' strings on the Git Settings
    inputs with t(I18nKey.SETTINGS$GIT_USERNAME_PLACEHOLDER) and
    t(I18nKey.SETTINGS$GIT_EMAIL_PLACEHOLDER).
  - mcp-server-form.tsx: replaced the hardcoded label='Timeout (seconds)'
    on the SHTTP timeout input with t(I18nKey.SETTINGS$MCP_TIMEOUT_LABEL).

All three new keys ship with translations for every locale agent-canvas
bundles (en/ja/zh-CN/zh-TW/ko-KR/no/it/pt/es/ar/fr/tr/de/uk/ca), and
make-i18n regenerates declaration.ts with matching enum members.

The companion upstream PR #14291 — which drops the
ENABLE_SANDBOX_GROUPING() feature-flag gate around the
sandbox-grouping-strategy dropdown — is a no-op here: the
sandbox-grouping field, the dropdown, and the feature flag were all
already stripped from agent-canvas during the original OSS port, and
sandbox_grouping_strategy is not exposed by openhands-agent-server's
settings schemas (verified against 1.20.1). Per the issue's own
acceptance criteria, this PR therefore does not re-introduce the
control; see .pr/issue-134/visual-verification.md for details.

Visual verification + demo GIF: .pr/issue-134/

This commit was created by an AI agent (OpenHands) on behalf of the user.

Co-authored-by: openhands <openhands@all-hands.dev>

2026-05-07 12:54:56 -04:00

44 KiB

1280x800px

Raw History