OpenHands/openhands-cli/tests/settings/test_default_agent_security_analyzer.py

"""Test that first-time settings screen usage creates a default agent and conversation with security analyzer."""

from unittest.mock import patch
import pytest
from openhands_cli.tui.settings.settings_screen import SettingsScreen
from openhands_cli.user_actions.settings_action import SettingsType
from openhands.sdk import LLM, Conversation, Workspace
from openhands.sdk.security.llm_analyzer import LLMSecurityAnalyzer
from pydantic import SecretStr


def test_first_time_settings_creates_default_agent_and_conversation_with_security_analyzer():
    """Test that using the settings screen for the first time creates a default agent and conversation with security analyzer."""
    
    # Create a settings screen instance (no conversation initially)
    screen = SettingsScreen(conversation=None)
    
    # Mock all the user interaction steps to simulate first-time setup
    with (
        patch(
            'openhands_cli.tui.settings.settings_screen.settings_type_confirmation',
            return_value=SettingsType.BASIC,
        ),
        patch(
            'openhands_cli.tui.settings.settings_screen.choose_llm_provider',
            return_value='openai',
        ),
        patch(
            'openhands_cli.tui.settings.settings_screen.choose_llm_model',
            return_value='gpt-4o-mini',
        ),
        patch(
            'openhands_cli.tui.settings.settings_screen.prompt_api_key',
            return_value='sk-test-key-123',
        ),
        patch(
            'openhands_cli.tui.settings.settings_screen.save_settings_confirmation',
            return_value=True,
        ),
    ):
        # Run the settings configuration workflow
        screen.configure_settings(first_time=True)
    
    # Load the saved agent from the store
    saved_agent = screen.agent_store.load()
    
    # Verify that an agent was created and saved
    assert saved_agent is not None, "Agent should be created and saved after first-time settings configuration"
    
    # Verify that the agent has the expected LLM configuration
    assert saved_agent.llm.model == 'openai/gpt-4o-mini', f"Expected model 'openai/gpt-4o-mini', got '{saved_agent.llm.model}'"
    assert saved_agent.llm.api_key.get_secret_value() == 'sk-test-key-123', "API key should match the provided value"
    
    # Test that a conversation can be created with the agent and security analyzer can be set
    conversation = Conversation(agent=saved_agent, workspace=Workspace(working_dir='/tmp'))
    
    # Set security analyzer using the new API
    security_analyzer = LLMSecurityAnalyzer()
    conversation.set_security_analyzer(security_analyzer)
    
    # Verify that the security analyzer was set correctly
    assert conversation.state.security_analyzer is not None, "Conversation should have a security analyzer"
    assert conversation.state.security_analyzer.kind == 'LLMSecurityAnalyzer', f"Expected security analyzer kind 'LLMSecurityAnalyzer', got '{conversation.state.security_analyzer.kind}'"


def test_first_time_settings_with_advanced_configuration():
    """Test that advanced settings also create a default agent and conversation with security analyzer."""
    
    screen = SettingsScreen(conversation=None)
    
    with (
        patch(
            'openhands_cli.tui.settings.settings_screen.settings_type_confirmation',
            return_value=SettingsType.ADVANCED,
        ),
        patch(
            'openhands_cli.tui.settings.settings_screen.prompt_custom_model',
            return_value='anthropic/claude-3-5-sonnet',
        ),
        patch(
            'openhands_cli.tui.settings.settings_screen.prompt_base_url',
            return_value='https://api.anthropic.com',
        ),
        patch(
            'openhands_cli.tui.settings.settings_screen.prompt_api_key',
            return_value='sk-ant-test-key',
        ),
        patch(
            'openhands_cli.tui.settings.settings_screen.choose_memory_condensation',
            return_value=True,
        ),
        patch(
            'openhands_cli.tui.settings.settings_screen.save_settings_confirmation',
            return_value=True,
        ),
    ):
        screen.configure_settings(first_time=True)
    
    saved_agent = screen.agent_store.load()
    
    # Verify agent creation
    assert saved_agent is not None, "Agent should be created with advanced settings"
    
    # Verify advanced settings were applied
    assert saved_agent.llm.model == 'anthropic/claude-3-5-sonnet', "Custom model should be set"
    assert saved_agent.llm.base_url == 'https://api.anthropic.com', "Base URL should be set"
    
    # Test that a conversation can be created with the agent and security analyzer can be set
    conversation = Conversation(agent=saved_agent, workspace=Workspace(working_dir='/tmp'))
    
    # Set security analyzer using the new API
    security_analyzer = LLMSecurityAnalyzer()
    conversation.set_security_analyzer(security_analyzer)
    
    # Verify that the security analyzer was set correctly
    assert conversation.state.security_analyzer is not None, "Conversation should have a security analyzer"
    assert conversation.state.security_analyzer.kind == 'LLMSecurityAnalyzer', "Security analyzer should be LLMSecurityAnalyzer"