github/OpenHands
1
0
Fork 0
mirror of https://github.com/OpenHands/OpenHands.git synced 2025-12-26 05:48:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(evaluation): solve graceful shutdown of docker containers (#106)

Browse Source 
* add atexit

* remove print

* fix typo
This commit is contained in:
Yufan Song 2024-03-23 14:37:20 -07:00 committed by GitHub
parent 78f8752246
commit fabdddca21
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
opendevin/sandbox/sandbox.py
View File

@ -10,6 +10,7 @@ import docker
import time
from typing import List, Tuple
from collections import namedtuple
import atexit
InputType = namedtuple("InputDtype", ["content"])
OutputType = namedtuple("OutputDtype", ["content"])
@ -53,6 +54,8 @@ class DockerInteractive:
self.restart_docker_container()
uid = os.getuid()
self.execute('useradd --shell /bin/bash -u {uid} -o -c \"\" -m devin && su devin')
# regester container cleanup function
atexit.register(self.cleanup)
def read_logs(self) -> str:
if not hasattr(self, "log_generator"):
@ -132,11 +135,10 @@ class DockerInteractive:
if self.container.status != "running":
raise Exception("Failed to start container")
def __del__(self):
# FIXME: this fails because python is already shutting down. How can we clean up?
# self.container.remove(force=True)
pass
# clean up the container, cannot do it in __del__ because the python interpreter is already shutting down
def cleanup(self):
self.container.remove(force=True)
print("Finish cleaning up Docker container")
if __name__ == "__main__":
import argparse