github/OpenHands
1
0
Fork 0
mirror of https://github.com/OpenHands/OpenHands.git synced 2025-12-26 05:48:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(frontend): skip flaky WebSocket broadcast tests (#11972)

Browse Source
This commit is contained in:
sp.wack 2025-12-09 18:57:26 +04:00 committed by GitHub
parent a9c76d0ed4
commit e18168020a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
frontend/__tests__/hooks/use-websocket.test.ts
View File

@ -1,3 +1,11 @@
/**
* TODO: Fix flaky WebSocket tests (https://github.com/OpenHands/OpenHands/issues/11944)
*
* Several tests in this file are skipped because they fail intermittently in CI
* but pass locally. The SUSPECTED root cause is that `wsLink.broadcast()` sends messages
* to ALL connected clients across all tests, causing cross-test contamination
* when tests run in parallel with Vitest v4.
*/
import { renderHook, waitFor } from "@testing-library/react";
import {
describe,
@ -51,7 +59,7 @@ describe("useWebSocket", () => {
expect(result.current.socket).toBeTruthy();
});
it("should handle incoming messages correctly", async () => {
it.skip("should handle incoming messages correctly", async () => {
const { result } = renderHook(() => useWebSocket("ws://acme.com/ws"));
// Wait for connection to be established
@ -114,7 +122,7 @@ describe("useWebSocket", () => {
expect(result.current.socket).toBeTruthy();
});
it("should close the WebSocket connection on unmount", async () => {
it.skip("should close the WebSocket connection on unmount", async () => {
const { result, unmount } = renderHook(() =>
useWebSocket("ws://acme.com/ws"),
);
@ -204,7 +212,7 @@ describe("useWebSocket", () => {
});
});
it("should call onMessage handler when WebSocket receives a message", async () => {
it.skip("should call onMessage handler when WebSocket receives a message", async () => {
const onMessageSpy = vi.fn();
const options = { onMessage: onMessageSpy };
@ -271,7 +279,7 @@ describe("useWebSocket", () => {
expect(onErrorSpy).toHaveBeenCalled();
});
it("should provide sendMessage function to send messages to WebSocket", async () => {
it.skip("should provide sendMessage function to send messages to WebSocket", async () => {
const { result } = renderHook(() => useWebSocket("ws://acme.com/ws"));
// Wait for connection to be established