github/OpenHands
1
0
Fork 0
mirror of https://github.com/OpenHands/OpenHands.git synced 2025-12-26 05:48:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

Agent session no longer stuck in starting on raised exception (#6703)

Browse Source
This commit is contained in:
tofarr 2025-02-13 12:24:44 +00:00 committed by GitHub
parent 312b9fbfb1
commit cb5e7f0130
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 38 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
openhands/runtime/impl/remote/remote_runtime.py
View File

@ -92,8 +92,9 @@ class RemoteRuntime(ActionExecutionClient):
async def connect(self):
try:
await call_sync_from_async(self._start_or_attach_to_runtime)
except AgentRuntimeNotReadyError:
self.log('error', 'Runtime failed to start, timed out before ready')
except Exception:
self.close()
self.log('error', 'Runtime failed to start')
raise
await call_sync_from_async(self.setup_initial_env)
self._runtime_initialized = True

69
openhands/server/session/agent_session.py
View File

@ -99,42 +99,43 @@ class AgentSession:
return
self._starting = True
self._started_at = time.time()
self._create_security_analyzer(config.security.security_analyzer)
await self._create_runtime(
runtime_name=runtime_name,
config=config,
agent=agent,
github_token=github_token,
selected_repository=selected_repository,
selected_branch=selected_branch,
)
self.controller = self._create_controller(
agent,
config.security.confirmation_mode,
max_iterations,
max_budget_per_task=max_budget_per_task,
agent_to_llm_config=agent_to_llm_config,
agent_configs=agent_configs,
)
if github_token:
self.event_stream.set_secrets(
{
'github_token': github_token.get_secret_value(),
}
)
if initial_message:
self.event_stream.add_event(initial_message, EventSource.USER)
self.event_stream.add_event(
ChangeAgentStateAction(AgentState.RUNNING), EventSource.ENVIRONMENT
)
else:
self.event_stream.add_event(
ChangeAgentStateAction(AgentState.AWAITING_USER_INPUT),
EventSource.ENVIRONMENT,
try:
self._create_security_analyzer(config.security.security_analyzer)
await self._create_runtime(
runtime_name=runtime_name,
config=config,
agent=agent,
github_token=github_token,
selected_repository=selected_repository,
selected_branch=selected_branch,
)
self._starting = False
self.controller = self._create_controller(
agent,
config.security.confirmation_mode,
max_iterations,
max_budget_per_task=max_budget_per_task,
agent_to_llm_config=agent_to_llm_config,
agent_configs=agent_configs,
)
if github_token:
self.event_stream.set_secrets(
{
'github_token': github_token.get_secret_value(),
}
)
if initial_message:
self.event_stream.add_event(initial_message, EventSource.USER)
self.event_stream.add_event(
ChangeAgentStateAction(AgentState.RUNNING), EventSource.ENVIRONMENT
)
else:
self.event_stream.add_event(
ChangeAgentStateAction(AgentState.AWAITING_USER_INPUT),
EventSource.ENVIRONMENT,
)
finally:
self._starting = False
async def close(self):
"""Closes the Agent session"""