From c97e7082f76469aa7b6557b83adbf0ba7431d1c8 Mon Sep 17 00:00:00 2001 From: Tim O'Farrell Date: Wed, 7 Jan 2026 22:15:00 -0700 Subject: [PATCH] Making sure verify_repo_provider is_optional so log is debug not error (#12302) Co-authored-by: openhands --- openhands/app_server/app_conversation/skill_loader.py | 8 ++++++-- tests/unit/app_server/test_skill_loader.py | 6 ++++-- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/openhands/app_server/app_conversation/skill_loader.py b/openhands/app_server/app_conversation/skill_loader.py index d237ff0542..3bcbdbe4b2 100644 --- a/openhands/app_server/app_conversation/skill_loader.py +++ b/openhands/app_server/app_conversation/skill_loader.py @@ -134,7 +134,9 @@ async def _is_gitlab_repository(repo_name: str, user_context: UserContext) -> bo """ try: provider_handler = await user_context.get_provider_handler() # type: ignore[attr-defined] - repository = await provider_handler.verify_repo_provider(repo_name) + repository = await provider_handler.verify_repo_provider( + repo_name, is_optional=True + ) return repository.git_provider == ProviderType.GITLAB except Exception: # If we can't determine the provider, assume it's not GitLab @@ -156,7 +158,9 @@ async def _is_azure_devops_repository( """ try: provider_handler = await user_context.get_provider_handler() # type: ignore[attr-defined] - repository = await provider_handler.verify_repo_provider(repo_name) + repository = await provider_handler.verify_repo_provider( + repo_name, is_optional=True + ) return repository.git_provider == ProviderType.AZURE_DEVOPS except Exception: # If we can't determine the provider, assume it's not Azure DevOps diff --git a/tests/unit/app_server/test_skill_loader.py b/tests/unit/app_server/test_skill_loader.py index e4daadfa14..45ee7c8825 100644 --- a/tests/unit/app_server/test_skill_loader.py +++ b/tests/unit/app_server/test_skill_loader.py @@ -702,7 +702,9 @@ class TestIsGitlabRepository: # Assert assert result is True - mock_provider_handler.verify_repo_provider.assert_called_once_with('owner/repo') + mock_provider_handler.verify_repo_provider.assert_called_once_with( + 'owner/repo', is_optional=True + ) @pytest.mark.asyncio async def test_is_gitlab_repository_false(self): @@ -759,7 +761,7 @@ class TestIsAzureDevOpsRepository: # Assert assert result is True mock_provider_handler.verify_repo_provider.assert_called_once_with( - 'org/project/repo' + 'org/project/repo', is_optional=True ) @pytest.mark.asyncio