github/OpenHands
1
0
Fork 0
mirror of https://github.com/OpenHands/OpenHands.git synced 2025-12-26 05:48:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

test(runtime) #4623: file permission when running the file_editor (#4628)

Browse Source 
Co-authored-by: openhands <openhands@all-hands.dev>
This commit is contained in:
Xingyao Wang 2024-10-30 15:34:34 -05:00 committed by GitHub
parent 0ea5dcc781
commit c0a0d46eb2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 82 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

82
tests/runtime/test_ipython.py
View File

@ -232,3 +232,85 @@ def test_ipython_package_install(temp_dir, runtime_cls, run_as_openhands):
)
_close_test_runtime(runtime)
def test_ipython_file_editor_permissions_as_openhands(temp_dir, runtime_cls):
"""Test file editor permission behavior when running as different users."""
runtime = _load_runtime(temp_dir, runtime_cls, run_as_openhands=True)
sandbox_dir = _get_sandbox_folder(runtime)
# Create a file owned by root with restricted permissions
action = CmdRunAction(
command='sudo touch /root/test.txt && sudo chmod 600 /root/test.txt'
)
logger.info(action, extra={'msg_type': 'ACTION'})
obs = runtime.run_action(action)
logger.info(obs, extra={'msg_type': 'OBSERVATION'})
assert obs.exit_code == 0
# Try to view the file as openhands user - should fail with permission denied
test_code = "print(file_editor(command='view', path='/root/test.txt'))"
action = IPythonRunCellAction(code=test_code)
logger.info(action, extra={'msg_type': 'ACTION'})
obs = runtime.run_action(action)
logger.info(obs, extra={'msg_type': 'OBSERVATION'})
assert 'Permission denied' in obs.content
# Try to edit the file as openhands user - should fail with permission denied
test_code = "print(file_editor(command='str_replace', path='/root/test.txt', old_str='', new_str='test'))"
action = IPythonRunCellAction(code=test_code)
logger.info(action, extra={'msg_type': 'ACTION'})
obs = runtime.run_action(action)
logger.info(obs, extra={'msg_type': 'OBSERVATION'})
assert 'Permission denied' in obs.content
# Try to create a file in root directory - should fail with permission denied
test_code = (
"print(file_editor(command='create', path='/root/new.txt', file_text='test'))"
)
action = IPythonRunCellAction(code=test_code)
logger.info(action, extra={'msg_type': 'ACTION'})
obs = runtime.run_action(action)
logger.info(obs, extra={'msg_type': 'OBSERVATION'})
assert 'Permission denied' in obs.content
# Try to use file editor in openhands sandbox directory - should work
test_code = f"""
# Create file
print(file_editor(command='create', path='{sandbox_dir}/test.txt', file_text='Line 1\\nLine 2\\nLine 3'))
# View file
print(file_editor(command='view', path='{sandbox_dir}/test.txt'))
# Edit file
print(file_editor(command='str_replace', path='{sandbox_dir}/test.txt', old_str='Line 2', new_str='New Line 2'))
# Undo edit
print(file_editor(command='undo_edit', path='{sandbox_dir}/test.txt'))
"""
action = IPythonRunCellAction(code=test_code)
logger.info(action, extra={'msg_type': 'ACTION'})
obs = runtime.run_action(action)
logger.info(obs, extra={'msg_type': 'OBSERVATION'})
assert 'File created successfully' in obs.content
assert 'Line 1' in obs.content
assert 'Line 2' in obs.content
assert 'Line 3' in obs.content
assert 'New Line 2' in obs.content
assert 'Last edit to' in obs.content
assert 'undone successfully' in obs.content
# Clean up
action = CmdRunAction(command=f'rm -f {sandbox_dir}/test.txt')
logger.info(action, extra={'msg_type': 'ACTION'})
obs = runtime.run_action(action)
logger.info(obs, extra={'msg_type': 'OBSERVATION'})
assert obs.exit_code == 0
action = CmdRunAction(command='sudo rm -f /root/test.txt')
logger.info(action, extra={'msg_type': 'ACTION'})
obs = runtime.run_action(action)
logger.info(obs, extra={'msg_type': 'OBSERVATION'})
assert obs.exit_code == 0
_close_test_runtime(runtime)