github/OpenHands
1
0
Fork 0
mirror of https://github.com/OpenHands/OpenHands.git synced 2025-12-26 05:48:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

properly exit loop on finish (#1210)

Browse Source
This commit is contained in:
Robert Brennan 2024-04-18 11:03:29 -04:00 committed by GitHub
parent 6b0408d47c
commit af262c17f1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 18 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
opendevin/controller/agent_controller.py
View File

@ -37,7 +37,6 @@ class AgentController:
state: State | None = None
_task_state: TaskState = TaskState.INIT
_finished: bool = False
_cur_step: int = 0
def __init__(
@ -89,25 +88,28 @@ class AgentController:
raise ValueError('Task is not in running state')
for i in range(self._cur_step, self.max_iterations):
self._cur_step = i
try:
self._finished = await self.step(i)
finished = await self.step(i)
if finished:
self._task_state = TaskState.FINISHED
except Exception as e:
logger.error('Error in loop', exc_info=True)
raise e
match self._task_state:
case TaskState.FINISHED, TaskState.STOPPED:
await self.reset_task() # type: ignore[unreachable]
break
case TaskState.PAUSED:
# save current state for resuming
self._cur_step = i + 1 # type: ignore[unreachable]
await self.notify_task_state_changed()
break
if not self._finished:
logger.info('Exited before finishing the task.')
self.agent.reset()
if self._task_state == TaskState.FINISHED:
logger.info('Task finished by agent')
await self.reset_task()
break
elif self._task_state == TaskState.STOPPED:
logger.info('Task stopped by user')
await self.reset_task()
break
elif self._task_state == TaskState.PAUSED:
logger.info('Task paused')
self._cur_step = i + 1
await self.notify_task_state_changed()
break
async def start(self, task: str):
"""Starts the agent controller with a task.
@ -133,6 +135,7 @@ class AgentController:
self.state = None
self._cur_step = 0
self._task_state = TaskState.INIT
self.agent.reset()
await self.notify_task_state_changed()
async def set_task_state_to(self, state: TaskState):