github/OpenHands
1
0
Fork 0
mirror of https://github.com/OpenHands/OpenHands.git synced 2025-12-26 05:48:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

(fix) test_runtime.py parametrization for box_class (#3186)

Browse Source 
* fix test_runtime.py parametrization; prevent duplicate test runs

* trivial file change to unblock stuck CI workflow

* fix print_method_name fixture in test_runtime (yield was missing)

* revert wrong param fixtures
This commit is contained in:
tobitege 2024-07-31 19:30:10 +02:00 committed by GitHub
parent 0cf4e1ecf3
commit 938ed027c2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 15 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
tests/unit/test_runtime.py
View File

@ -37,6 +37,7 @@ def print_method_name(request):
print('\n########################################################################')
print(f'Running test: {request.node.name}')
print('########################################################################')
yield
@pytest.fixture
@ -48,18 +49,23 @@ TEST_RUNTIME = os.getenv('TEST_RUNTIME', 'both')
PY3_FOR_TESTING = '/opendevin/miniforge3/bin/mamba run -n base python3'
# This assures that all tests run together for each runtime, not alternating between them,
# which caused them to fail previously.
@pytest.fixture(scope='module')
def box_class(request):
time.sleep(1)
# Depending on TEST_RUNTIME, feed the appropriate box class(es) to the test.
def get_box_classes():
runtime = TEST_RUNTIME
if runtime.lower() == 'eventstream':
return EventStreamRuntime
return [EventStreamRuntime]
elif runtime.lower() == 'server':
return ServerRuntime
return [ServerRuntime]
else:
return pytest.param([EventStreamRuntime, ServerRuntime])
return [EventStreamRuntime, ServerRuntime]
# This assures that all tests run together per runtime, not alternating between them,
# which cause errors (especially outside GitHub actions).
@pytest.fixture(scope='module', params=get_box_classes())
def box_class(request):
time.sleep(2)
return request.param
# TODO: We will change this to `run_as_user` when `ServerRuntime` is deprecated.
@ -129,6 +135,7 @@ async def _load_runtime(
container_image=cur_container_image,
)
await runtime.ainit()
elif box_class == ServerRuntime:
runtime = ServerRuntime(
config=config, event_stream=event_stream, sid=sid, plugins=plugins