From 88acaa84992db03edcb45c5db8eb787d96379f5d Mon Sep 17 00:00:00 2001 From: neubig Date: Sun, 30 Aug 2026 01:44:17 +0000 Subject: [PATCH] test: align Docker auth expectation with key policy Co-authored-by: openhands --- playwright.mock-llm-docker.config.ts | 6 ++---- tests/e2e/mock-llm/backends/mock-llm-auth-modes.spec.ts | 7 +++++-- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/playwright.mock-llm-docker.config.ts b/playwright.mock-llm-docker.config.ts index d0b9791612..8e80c7760a 100644 --- a/playwright.mock-llm-docker.config.ts +++ b/playwright.mock-llm-docker.config.ts @@ -77,6 +77,7 @@ const MOCK_LLM_PYTHON = process.env.MOCK_LLM_PYTHON ?? "python3"; process.env.MOCK_LLM_BACKEND_URL = `http://localhost:${INGRESS_PORT}`; process.env.MOCK_LLM_PORT = MOCK_LLM_PORT; process.env.MOCK_LLM_PUBLIC_MODE_URL = `http://localhost:${PUBLIC_MODE_PORT}`; +process.env.MOCK_LLM_DOCKER_MODE = "true"; process.env.VITE_SESSION_API_KEY = sessionApiKey; // MOCK_LLM_AGENT_URL — the URL the agent-server inside Docker uses to @@ -150,10 +151,7 @@ export default defineConfig({ globalTimeout: process.env.CI ? ciGlobalTimeoutMs : 0, // 20 min hard cap in CI reporter: [ ["line"], - [ - "json", - { outputFile: "test-results-mock-llm-docker/results.json" }, - ], + ["json", { outputFile: "test-results-mock-llm-docker/results.json" }], [ "html", { diff --git a/tests/e2e/mock-llm/backends/mock-llm-auth-modes.spec.ts b/tests/e2e/mock-llm/backends/mock-llm-auth-modes.spec.ts index 38eb85f85c..0c0d308a8f 100644 --- a/tests/e2e/mock-llm/backends/mock-llm-auth-modes.spec.ts +++ b/tests/e2e/mock-llm/backends/mock-llm-auth-modes.spec.ts @@ -99,13 +99,16 @@ test.describe("auth mode: fresh install with runtime-injected key", () => { }); expect(settingsResp.ok()).toBe(true); - // Sanity check: the runtime key landed on the window global. + // Docker's externally reachable listener must not expose the key. The + // loopback-only npm launcher injects it for the local first-run path. const injected = await page.evaluate( () => (window as unknown as Record) .__AGENT_CANVAS_SESSION_API_KEY__, ); - expect(injected).toBe(SESSION_API_KEY); + expect(injected).toBe( + process.env.MOCK_LLM_DOCKER_MODE ? undefined : SESSION_API_KEY, + ); }); });