From 73ded7de109105c6987fb5d1e091700ec0922b2f Mon Sep 17 00:00:00 2001 From: Graham Neubig Date: Mon, 23 Sep 2024 16:57:10 -0400 Subject: [PATCH] Make drop_params default in llm_config (#4012) --- openhands/core/config/llm_config.py | 2 +- openhands/llm/llm.py | 6 ++---- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/openhands/core/config/llm_config.py b/openhands/core/config/llm_config.py index 3a0c942c42..af766045ea 100644 --- a/openhands/core/config/llm_config.py +++ b/openhands/core/config/llm_config.py @@ -64,7 +64,7 @@ class LLMConfig: input_cost_per_token: float | None = None output_cost_per_token: float | None = None ollama_base_url: str | None = None - drop_params: bool | None = None + drop_params: bool = True disable_vision: bool | None = None caching_prompt: bool = False log_completions: bool = False diff --git a/openhands/llm/llm.py b/openhands/llm/llm.py index 89b9d33e7d..9e4c00399f 100644 --- a/openhands/llm/llm.py +++ b/openhands/llm/llm.py @@ -132,9 +132,6 @@ class LLM: ): self.config.max_output_tokens = self.model_info['max_tokens'] - if self.config.drop_params: - litellm.drop_params = self.config.drop_params - # This only seems to work with Google as the provider, not with OpenRouter! gemini_safety_settings = ( [ @@ -170,6 +167,7 @@ class LLM: timeout=self.config.timeout, temperature=self.config.temperature, top_p=self.config.top_p, + drop_params=self.config.drop_params, **( {'safety_settings': gemini_safety_settings} if gemini_safety_settings is not None @@ -298,7 +296,7 @@ class LLM: timeout=self.config.timeout, temperature=self.config.temperature, top_p=self.config.top_p, - drop_params=True, + drop_params=self.config.drop_params, **( {'safety_settings': gemini_safety_settings} if gemini_safety_settings is not None