github/OpenHands
1
0
Fork 0
mirror of https://github.com/OpenHands/OpenHands.git synced 2025-12-26 05:48:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add make lint to pre-commit hook (#9795)

Browse Source 
Co-authored-by: openhands <openhands@all-hands.dev>
This commit is contained in:
Xingyao Wang 2025-07-22 12:36:54 -04:00 committed by GitHub
parent f62ed911d2
commit 58ea7b5248
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 13 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
.openhands/pre-commit.sh
View File

@ -1,29 +1,32 @@
#!/bin/bash #!/bin/bash
echo "Running OpenHands pre-commit hook..." echo "Running OpenHands pre-commit hook..."
echo "This hook runs 'make lint' to ensure code quality before committing."
# Store the exit code to return at the end # Store the exit code to return at the end
# This allows us to be additive to existing pre-commit hooks # This allows us to be additive to existing pre-commit hooks
EXIT_CODE=0 EXIT_CODE=0
# Run make lint to check both frontend and backend code
echo "Running linting checks with 'make lint'..."
make lint
if [ $? -ne 0 ]; then
echo "Linting failed. Please fix the issues before committing."
EXIT_CODE=1
else
echo "Linting checks passed!"
fi
# Check if frontend directory has changed # Check if frontend directory has changed
frontend_changes=$(git diff --cached --name-only | grep "^frontend/") frontend_changes=$(git diff --cached --name-only | grep "^frontend/")
if [ -n "$frontend_changes" ]; then if [ -n "$frontend_changes" ]; then
echo "Frontend changes detected. Running frontend checks..." echo "Frontend changes detected. Running additional frontend checks..."
# Check if frontend directory exists # Check if frontend directory exists
if [ -d "frontend" ]; then if [ -d "frontend" ]; then
# Change to frontend directory # Change to frontend directory
cd frontend || exit 1 cd frontend || exit 1
# Run lint:fix
echo "Running npm lint:fix..."
npm run lint:fix
if [ $? -ne 0 ]; then
echo "Frontend linting failed. Please fix the issues before committing."
EXIT_CODE=1
fi
# Run build # Run build
echo "Running npm build..." echo "Running npm build..."
npm run build npm run build
@ -50,7 +53,7 @@ if [ -n "$frontend_changes" ]; then
echo "Frontend directory not found. Skipping frontend checks." echo "Frontend directory not found. Skipping frontend checks."
fi fi
else else
echo "No frontend changes detected. Skipping frontend checks." echo "No frontend changes detected. Skipping additional frontend checks."
fi fi
# Run any existing pre-commit hooks that might have been installed by the user # Run any existing pre-commit hooks that might have been installed by the user