github/OpenHands
1
0
Fork 0
mirror of https://github.com/OpenHands/OpenHands.git synced 2025-12-26 05:48:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

feat: make websocket client wait timeout configurable (#11405)

Browse Source 
Co-authored-by: Alex <alex@cellect.ai>
Co-authored-by: Graham Neubig <neubig@gmail.com>
This commit is contained in:
olyashok 2025-10-16 12:49:50 -04:00 committed by GitHub
parent a237b578c0
commit 5219f85bfa
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 22 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
openhands/core/config/openhands_config.py
View File

@ -112,6 +112,10 @@ class OpenHandsConfig(BaseModel):
max_concurrent_conversations: int = Field(
default=3
) # Maximum number of concurrent agent loops allowed per user
client_wait_timeout: int = Field(
default=30,
description='Timeout in seconds for waiting for websocket client connection during initialization',
)
mcp_host: str = Field(default=f'localhost:{os.getenv("port", 3000)}')
mcp: MCPConfig = Field(default_factory=MCPConfig)
kubernetes: KubernetesConfig = Field(default_factory=KubernetesConfig)

24
openhands/server/session/session.py
View File

@ -390,9 +390,15 @@ class WebSession:
_waiting_times = 1
if self.sio:
# Get timeout from configuration, default to 30 seconds
client_wait_timeout = self.config.client_wait_timeout
self.logger.debug(
f'Using client wait timeout: {client_wait_timeout}s for session {self.sid}'
)
# Wait once during initialization to avoid event push failures during websocket connection intervals
while self._wait_websocket_initial_complete and (
time.time() - _start_time < 2
time.time() - _start_time < client_wait_timeout
):
if bool(
self.sio.manager.rooms.get('/', {}).get(
@ -400,12 +406,18 @@ class WebSession:
)
):
break
self.logger.warning(
f'There is no listening client in the current room,'
f' waiting for the {_waiting_times}th attempt: {self.sid}'
)
# Progressive backoff: start with 0.1s, increase to 1s after 10 attempts
sleep_duration = 0.1 if _waiting_times <= 10 else 1.0
# Log every 2 seconds to reduce spam
if _waiting_times % (20 if sleep_duration == 0.1 else 2) == 0:
self.logger.debug(
f'There is no listening client in the current room,'
f' waiting for the {_waiting_times}th attempt (timeout: {client_wait_timeout}s): {self.sid}'
)
_waiting_times += 1
await asyncio.sleep(0.1)
await asyncio.sleep(sleep_duration)
self._wait_websocket_initial_complete = False
await self.sio.emit('oh_event', data, to=ROOM_KEY.format(sid=self.sid))