github/OpenHands
1
0
Fork 0
mirror of https://github.com/OpenHands/OpenHands.git synced 2026-03-22 13:47:19 +08:00
Code Issues Packages Projects Releases Wiki Activity

Make SlackTeamStore fully async (#13160)

Browse Source 
Co-authored-by: openhands <openhands@all-hands.dev>
This commit is contained in:
Tim O'Farrell
2026-03-03 07:07:44 -07:00
committed by GitHub
parent 6f1a7ddadd
commit 501bf64312
8 changed files with 44 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
enterprise/tests/unit/integrations/slack/test_slack_v1_callback_processor.py
View File

@@ -145,9 +145,9 @@ class TestSlackV1CallbackProcessor:
"""Test that processor handles double callback correctly and processes both times."""
conversation_id = uuid4()
# Mock SlackTeamStore
# Mock SlackTeamStore (async method)
mock_store = MagicMock()
mock_store.get_team_bot_token.return_value = 'xoxb-test-token'
mock_store.get_team_bot_token = AsyncMock(return_value='xoxb-test-token')
mock_slack_team_store.return_value = mock_store
# Mock successful summary generation
@@ -208,9 +208,9 @@ class TestSlackV1CallbackProcessor:
"""Test successful end-to-end callback execution."""
conversation_id = uuid4()
# Mock SlackTeamStore
# Mock SlackTeamStore (async method)
mock_store = MagicMock()
mock_store.get_team_bot_token.return_value = 'xoxb-test-token'
mock_store.get_team_bot_token = AsyncMock(return_value='xoxb-test-token')
mock_slack_team_store.return_value = mock_store
# Mock summary instruction
@@ -287,9 +287,9 @@ class TestSlackV1CallbackProcessor:
expected_error,
):
"""Test error handling when bot access token is missing or empty."""
# Mock SlackTeamStore to return the test token
# Mock SlackTeamStore to return the test token (async method)
mock_store = MagicMock()
mock_store.get_team_bot_token.return_value = bot_token
mock_store.get_team_bot_token = AsyncMock(return_value=bot_token)
mock_slack_team_store.return_value = mock_store
# Mock successful summary generation
@@ -327,9 +327,9 @@ class TestSlackV1CallbackProcessor:
expected_error,
):
"""Test error handling for various Slack API errors."""
# Mock SlackTeamStore
# Mock SlackTeamStore (async method)
mock_store = MagicMock()
mock_store.get_team_bot_token.return_value = 'xoxb-test-token'
mock_store.get_team_bot_token = AsyncMock(return_value='xoxb-test-token')
mock_slack_team_store.return_value = mock_store
# Mock successful summary generation
@@ -392,9 +392,9 @@ class TestSlackV1CallbackProcessor:
"""Test error handling for various agent server errors."""
conversation_id = uuid4()
# Mock SlackTeamStore
# Mock SlackTeamStore (async method)
mock_store = MagicMock()
mock_store.get_team_bot_token.return_value = 'xoxb-test-token'
mock_store.get_team_bot_token = AsyncMock(return_value='xoxb-test-token')
mock_slack_team_store.return_value = mock_store
# Mock summary instruction

6
enterprise/tests/unit/test_slack_callback_processor.py
View File

@@ -240,12 +240,12 @@ class TestSlackCallbackProcessor:
return_value=(mock_slack_user, mock_saas_user_auth)
)
# Mock the SlackFactory
# Mock the SlackFactory (async method)
with patch(
'server.conversation_callback_processor.slack_callback_processor.SlackFactory'
) as mock_slack_factory:
mock_slack_factory.create_slack_view_from_payload.return_value = (
mock_slack_view
mock_slack_factory.create_slack_view_from_payload = AsyncMock(
return_value=mock_slack_view
)
mock_slack_manager.send_message = AsyncMock()