mirror of
https://github.com/OpenHands/OpenHands.git
synced 2026-03-22 05:37:20 +08:00
fix(mcp): skip conversation link when conversation_id is None (#12941)
Signed-off-by: machov <mv1742@nyu.edu> Co-authored-by: Rohit Malhotra <rohitvinodmalhotra@gmail.com>
This commit is contained in:
@@ -123,3 +123,29 @@ async def test_get_conversation_link_empty_body():
|
||||
|
||||
# Verify that get_user was called
|
||||
mock_service.get_user.assert_called_once()
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_get_conversation_link_none_conversation_id():
|
||||
"""Test get_conversation_link returns body unchanged when conversation_id is None."""
|
||||
mock_service = AsyncMock(spec=GitService)
|
||||
|
||||
with patch('openhands.server.routes.mcp.server_config') as mock_config:
|
||||
mock_config.app_mode = AppMode.SAAS
|
||||
|
||||
body = 'This is the PR body.'
|
||||
|
||||
# Test with None conversation_id
|
||||
result = await get_conversation_link(
|
||||
service=mock_service, conversation_id=None, body=body
|
||||
)
|
||||
assert result == body
|
||||
|
||||
# Test with empty string conversation_id
|
||||
result = await get_conversation_link(
|
||||
service=mock_service, conversation_id='', body=body
|
||||
)
|
||||
assert result == body
|
||||
|
||||
# Verify get_user was never called (early return)
|
||||
mock_service.get_user.assert_not_called()
|
||||
|
||||
Reference in New Issue
Block a user