github/OpenHands
1
0
Fork 0
mirror of https://github.com/OpenHands/OpenHands.git synced 2025-12-26 05:48:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

Minor auth fixes (#4699)

Browse Source
This commit is contained in:
Robert Brennan 2024-11-01 18:33:29 -07:00 committed by GitHub
parent 9d3b77bffc
commit 36623a16da
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 10 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
frontend/src/api/open-hands.ts
View File

@ -141,9 +141,13 @@ class OpenHands {
* @returns Response with authentication status and user info if successful
*/
static async authenticate(): Promise<Response> {
return request(`/api/authenticate`, {
method: "POST",
});
return request(
`/api/authenticate`,
{
method: "POST",
},
true,
);
}
}

8
frontend/src/routes/oauth.github.callback.tsx
View File

@ -15,14 +15,6 @@ export const clientLoader = async ({ request }: ClientLoaderFunctionArgs) => {
await OpenHands.getGitHubAccessToken(code);
localStorage.setItem("ghToken", accessToken);
const authResponse = await OpenHands.authenticate();
if (!authResponse.ok) {
localStorage.removeItem("ghToken");
return json(
{ error: "Failed to authenticate with GitHub" },
{ status: authResponse.status },
);
}
return redirect("/");
}

1
frontend/src/services/api.ts
View File

@ -7,6 +7,7 @@ const UNAUTHED_ROUTE_PREFIXES = [
"/api/authenticate",
"/api/options/",
"/config.json",
"/api/github/callback",
];
export async function request(

6
openhands/server/github.py
View File

@ -76,11 +76,9 @@ class UserVerifier:
return False
# Global instance of user verifier
user_verifier = UserVerifier()
async def authenticate_github_user(auth_token) -> bool:
user_verifier = UserVerifier()
logger.info('Checking GitHub token')
if not auth_token: