Add back microagent files with special handling for user inputs (#8139)

Co-authored-by: openhands <openhands@all-hands.dev>
Co-authored-by: Engel Nyst <enyst@users.noreply.github.com>

tests/runtime/test_microagent.py

@@ -1,6 +1,7 @@
 """Tests for microagent loading in runtime."""
 
 import os
+import tempfile
 from pathlib import Path
 from unittest.mock import AsyncMock, MagicMock, patch
 
@@ -13,7 +14,13 @@ from conftest import (
 from openhands.core.config import MCPConfig
 from openhands.core.config.mcp_config import MCPStdioServerConfig
 from openhands.mcp.utils import add_mcp_tools_to_agent
-from openhands.microagent import KnowledgeMicroagent, RepoMicroagent
+from openhands.microagent.microagent import (
+    BaseMicroagent,
+    KnowledgeMicroagent,
+    RepoMicroagent,
+    TaskMicroagent,
+)
+from openhands.microagent.types import MicroagentType
 
 
 def _create_test_microagents(test_dir: str):
@@ -173,6 +180,176 @@ Repository-specific test instructions.
         _close_test_runtime(runtime)
 
 
+def test_task_microagent_creation():
+    """Test that a TaskMicroagent is created correctly."""
+    content = """---
+name: test_task
+version: 1.0.0
+author: openhands
+agent: CodeActAgent
+triggers:
+- /test_task
+inputs:
+  - name: TEST_VAR
+    description: "Test variable"
+---
+
+This is a test task microagent with a variable: ${test_var}.
+"""
+
+    with tempfile.NamedTemporaryFile(suffix='.md') as f:
+        f.write(content.encode())
+        f.flush()
+
+        agent = BaseMicroagent.load(f.name)
+
+        assert isinstance(agent, TaskMicroagent)
+        assert agent.type == MicroagentType.TASK
+        assert agent.name == 'test_task'
+        assert '/test_task' in agent.triggers
+        assert "If the user didn't provide any of these variables" in agent.content
+
+
+def test_task_microagent_variable_extraction():
+    """Test that variables are correctly extracted from the content."""
+    content = """---
+name: test_task
+version: 1.0.0
+author: openhands
+agent: CodeActAgent
+triggers:
+- /test_task
+inputs:
+  - name: var1
+    description: "Variable 1"
+---
+
+This is a test with variables: ${var1}, ${var2}, and ${var3}.
+"""
+
+    with tempfile.NamedTemporaryFile(suffix='.md') as f:
+        f.write(content.encode())
+        f.flush()
+
+        agent = BaseMicroagent.load(f.name)
+
+        assert isinstance(agent, TaskMicroagent)
+        variables = agent.extract_variables(agent.content)
+        assert set(variables) == {'var1', 'var2', 'var3'}
+        assert agent.requires_user_input()
+
+
+def test_knowledge_microagent_no_prompt():
+    """Test that a regular KnowledgeMicroagent doesn't get the prompt."""
+    content = """---
+name: test_knowledge
+version: 1.0.0
+author: openhands
+agent: CodeActAgent
+triggers:
+- test_knowledge
+---
+
+This is a test knowledge microagent.
+"""
+
+    with tempfile.NamedTemporaryFile(suffix='.md') as f:
+        f.write(content.encode())
+        f.flush()
+
+        agent = BaseMicroagent.load(f.name)
+
+        assert isinstance(agent, KnowledgeMicroagent)
+        assert agent.type == MicroagentType.KNOWLEDGE
+        assert "If the user didn't provide any of these variables" not in agent.content
+
+
+def test_task_microagent_trigger_addition():
+    """Test that a trigger is added if not present."""
+    content = """---
+name: test_task
+version: 1.0.0
+author: openhands
+agent: CodeActAgent
+inputs:
+  - name: TEST_VAR
+    description: "Test variable"
+---
+
+This is a test task microagent.
+"""
+
+    with tempfile.NamedTemporaryFile(suffix='.md') as f:
+        f.write(content.encode())
+        f.flush()
+
+        agent = BaseMicroagent.load(f.name)
+
+        assert isinstance(agent, TaskMicroagent)
+        assert '/test_task' in agent.triggers
+
+
+def test_task_microagent_no_duplicate_trigger():
+    """Test that a trigger is not duplicated if already present."""
+    content = """---
+name: test_task
+version: 1.0.0
+author: openhands
+agent: CodeActAgent
+triggers:
+- /test_task
+- another_trigger
+inputs:
+  - name: TEST_VAR
+    description: "Test variable"
+---
+
+This is a test task microagent.
+"""
+
+    with tempfile.NamedTemporaryFile(suffix='.md') as f:
+        f.write(content.encode())
+        f.flush()
+
+        agent = BaseMicroagent.load(f.name)
+
+        assert isinstance(agent, TaskMicroagent)
+        assert agent.triggers.count('/test_task') == 1  # No duplicates
+        assert len(agent.triggers) == 2
+        assert 'another_trigger' in agent.triggers
+        assert '/test_task' in agent.triggers
+
+
+def test_task_microagent_match_trigger():
+    """Test that a task microagent matches its trigger correctly."""
+    content = """---
+name: test_task
+version: 1.0.0
+author: openhands
+agent: CodeActAgent
+triggers:
+- /test_task
+inputs:
+  - name: TEST_VAR
+    description: "Test variable"
+---
+
+This is a test task microagent.
+"""
+
+    with tempfile.NamedTemporaryFile(suffix='.md') as f:
+        f.write(content.encode())
+        f.flush()
+
+        agent = BaseMicroagent.load(f.name)
+
+        assert isinstance(agent, TaskMicroagent)
+        assert agent.match_trigger('/test_task') == '/test_task'
+        assert agent.match_trigger('  /test_task  ') == '/test_task'
+        assert agent.match_trigger('This contains /test_task') == '/test_task'
+        assert agent.match_trigger('/other_task') is None
+
+
 def test_default_tools_microagent_exists():
     """Test that the default-tools microagent exists in the global microagents directory."""
     # Get the path to the global microagents directory