github/OpenHands
1
0
Fork 0
mirror of https://github.com/OpenHands/OpenHands.git synced 2025-12-26 05:48:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(frontend): rename settings organization members route to settings org members for consistency (#11989)

Browse Source
This commit is contained in:
Hiep Le 2025-12-10 21:49:45 +07:00 committed by GitHub
parent 4b6288a5ac
commit 33f3861d95
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
6 changed files with 10 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
frontend/__tests__/components/features/user/user-context-menu.test.tsx
View File

@ -74,8 +74,7 @@ describe("UserContextMenu", () => {
// Verify that navigation items are rendered (except organization-members/org which are filtered out)
SAAS_NAV_ITEMS.filter(
(item) =>
item.to !== "/settings/organization-members" &&
item.to !== "/settings/org",
item.to !== "/settings/org-members" && item.to !== "/settings/org",
).forEach((item) => {
expect(screen.getByText(item.text)).toBeInTheDocument();
});
@ -238,7 +237,7 @@ describe("UserContextMenu", () => {
expect(integrationsLink).toHaveAttribute("href", "/settings/integrations");
});
it("should navigate to /settings/organization-members when Manage Organization Members is clicked", async () => {
it("should navigate to /settings/org-members when Manage Organization Members is clicked", async () => {
renderUserContextMenu({ type: "admin", onClose: vi.fn });
const manageOrganizationMembersButton = screen.getByText(
@ -247,7 +246,7 @@ describe("UserContextMenu", () => {
await userEvent.click(manageOrganizationMembersButton);
expect(navigateMock).toHaveBeenCalledExactlyOnceWith(
"/settings/organization-members",
"/settings/org-members",
);
});

4
frontend/__tests__/routes/manage-organization-members.test.tsx
View File

@ -35,7 +35,7 @@ const RouteStub = createRoutesStub([
children: [
{
Component: ManageOrganizationMembersWithPortalRoot,
path: "/settings/organization-members",
path: "/settings/org-members",
},
{
Component: () => <div data-testid="user-settings" />,
@ -79,7 +79,7 @@ describe("Manage Organization Members Route", () => {
});
const renderManageOrganizationMembers = () =>
render(<RouteStub initialEntries={["/settings/organization-members"]} />, {
render(<RouteStub initialEntries={["/settings/org-members"]} />, {
wrapper: ({ children }) => (
<QueryClientProvider client={queryClient}>
{children}

2
frontend/src/components/features/settings/settings-navigation.tsx
View File

@ -100,7 +100,7 @@ export function SettingsNavigation({
.filter((navItem) => {
// if user is not an admin or no org is selected, do not show organization members/org settings
if (
(navItem.to === "/settings/organization-members" ||
(navItem.to === "/settings/org-members" ||
navItem.to === "/settings/org") &&
(isUser || !orgId)
) {

5
frontend/src/components/features/user/user-context-menu.tsx
View File

@ -65,8 +65,7 @@ export function UserContextMenu({ type, onClose }: UserContextMenuProps) {
// Filter out organization members/org nav items since they're already handled separately in the menu
let navItems = (isOss ? OSS_NAV_ITEMS : SAAS_NAV_ITEMS).filter(
(item) =>
item.to !== "/settings/organization-members" &&
item.to !== "/settings/org",
item.to !== "/settings/org-members" && item.to !== "/settings/org",
);
// Hide LLM settings when the feature flag is enabled
if (config?.FEATURE_FLAGS?.HIDE_LLM_SETTINGS) {
@ -88,7 +87,7 @@ export function UserContextMenu({ type, onClose }: UserContextMenuProps) {
};
const handleManageOrganizationMembersClick = () => {
navigate("/settings/organization-members");
navigate("/settings/org-members");
onClose();
};

2
frontend/src/constants/settings-nav.tsx
View File

@ -55,7 +55,7 @@ export const SAAS_NAV_ITEMS: SettingsNavItem[] = [
text: "SETTINGS$NAV_MCP",
},
{
to: "/settings/organization-members",
to: "/settings/org-members",
text: "Organization Members",
icon: <FiUsers size={22} />,
},

2
frontend/src/routes.ts
View File

@ -18,7 +18,7 @@ export default [
route("billing", "routes/billing.tsx"),
route("secrets", "routes/secrets-settings.tsx"),
route("api-keys", "routes/api-keys.tsx"),
route("organization-members", "routes/manage-organization-members.tsx"),
route("org-members", "routes/manage-organization-members.tsx"),
route("org", "routes/manage-org.tsx"),
]),
route("conversations/:conversationId", "routes/conversation.tsx"),