github/OpenHands
1
0
Fork 0
mirror of https://github.com/OpenHands/OpenHands.git synced 2025-12-26 05:48:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix flaky TestLocalFileStore tests (#8569)

Browse Source 
Co-authored-by: openhands <openhands@all-hands.dev>
This commit is contained in:
Graham Neubig 2025-05-18 06:37:28 -04:00 committed by GitHub
parent 27c18f5bdd
commit 2dc7b37fe8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
tests/unit/test_storage.py
View File

@ -1,7 +1,8 @@
from __future__ import annotations
import os
import logging
import shutil
import tempfile
from abc import ABC
from dataclasses import dataclass, field
from io import BytesIO, StringIO
@ -108,11 +109,18 @@ class _StorageTest(ABC):
class TestLocalFileStore(TestCase, _StorageTest):
def setUp(self):
os.makedirs('./_test_files_tmp', exist_ok=True)
self.store = LocalFileStore('./_test_files_tmp')
# Create a unique temporary directory for each test instance
self.temp_dir = tempfile.mkdtemp(prefix='openhands_test_')
self.store = LocalFileStore(self.temp_dir)
def tearDown(self):
shutil.rmtree('./_test_files_tmp')
try:
# Use ignore_errors=True to avoid failures if directory is not empty
shutil.rmtree(self.temp_dir, ignore_errors=True)
except Exception as e:
logging.warning(
f'Failed to remove temporary directory {self.temp_dir}: {e}'
)
class TestInMemoryFileStore(TestCase, _StorageTest):