mirror of
https://github.com/OpenHands/OpenHands.git
synced 2026-03-22 13:47:19 +08:00
fix: add missing verifiedModels/verifiedProviders props in tests, run ruff format
- model-selector.test.tsx: pass verifiedModels and verifiedProviders to every <ModelSelector /> render call - settings-form.test.tsx: pass verifiedModels and verifiedProviders to <SettingsForm /> in test fixture - Run ruff format on all changed Python files (single→double quotes) - Fix D202 blank-line-after-docstring in public.py Co-authored-by: openhands <openhands@all-hands.dev>
This commit is contained in:
@@ -38,9 +38,18 @@ describe("ModelSelector", () => {
|
||||
},
|
||||
};
|
||||
|
||||
const verifiedModels = ["gpt-4o", "gpt-4o-mini"];
|
||||
const verifiedProviders = ["openai"];
|
||||
|
||||
it("should display the provider selector", async () => {
|
||||
const user = userEvent.setup();
|
||||
render(<ModelSelector models={models} />);
|
||||
render(
|
||||
<ModelSelector
|
||||
models={models}
|
||||
verifiedModels={verifiedModels}
|
||||
verifiedProviders={verifiedProviders}
|
||||
/>,
|
||||
);
|
||||
|
||||
const selector = screen.getByLabelText("LLM Provider");
|
||||
expect(selector).toBeInTheDocument();
|
||||
@@ -55,7 +64,13 @@ describe("ModelSelector", () => {
|
||||
|
||||
it("should disable the model selector if the provider is not selected", async () => {
|
||||
const user = userEvent.setup();
|
||||
render(<ModelSelector models={models} />);
|
||||
render(
|
||||
<ModelSelector
|
||||
models={models}
|
||||
verifiedModels={verifiedModels}
|
||||
verifiedProviders={verifiedProviders}
|
||||
/>,
|
||||
);
|
||||
|
||||
const modelSelector = screen.getByLabelText("LLM Model");
|
||||
expect(modelSelector).toBeDisabled();
|
||||
@@ -71,7 +86,13 @@ describe("ModelSelector", () => {
|
||||
|
||||
it("should display the model selector", async () => {
|
||||
const user = userEvent.setup();
|
||||
render(<ModelSelector models={models} />);
|
||||
render(
|
||||
<ModelSelector
|
||||
models={models}
|
||||
verifiedModels={verifiedModels}
|
||||
verifiedProviders={verifiedProviders}
|
||||
/>,
|
||||
);
|
||||
|
||||
const providerSelector = screen.getByLabelText("LLM Provider");
|
||||
await user.click(providerSelector);
|
||||
@@ -101,7 +122,13 @@ describe("ModelSelector", () => {
|
||||
|
||||
it("should call onModelChange when the model is changed", async () => {
|
||||
const user = userEvent.setup();
|
||||
render(<ModelSelector models={models} />);
|
||||
render(
|
||||
<ModelSelector
|
||||
models={models}
|
||||
verifiedModels={verifiedModels}
|
||||
verifiedProviders={verifiedProviders}
|
||||
/>,
|
||||
);
|
||||
|
||||
const providerSelector = screen.getByLabelText("LLM Provider");
|
||||
const modelSelector = screen.getByLabelText("LLM Model");
|
||||
@@ -128,7 +155,14 @@ describe("ModelSelector", () => {
|
||||
});
|
||||
|
||||
it("should have a default value if passed", async () => {
|
||||
render(<ModelSelector models={models} currentModel="azure/ada" />);
|
||||
render(
|
||||
<ModelSelector
|
||||
models={models}
|
||||
verifiedModels={verifiedModels}
|
||||
verifiedProviders={verifiedProviders}
|
||||
currentModel="azure/ada"
|
||||
/>,
|
||||
);
|
||||
|
||||
expect(screen.getByLabelText("LLM Provider")).toHaveValue("Azure");
|
||||
expect(screen.getByLabelText("LLM Model")).toHaveValue("ada");
|
||||
|
||||
@@ -17,6 +17,8 @@ describe("SettingsForm", () => {
|
||||
<SettingsForm
|
||||
settings={DEFAULT_SETTINGS}
|
||||
models={[DEFAULT_SETTINGS.llm_model]}
|
||||
verifiedModels={[]}
|
||||
verifiedProviders={["openhands"]}
|
||||
onClose={onCloseMock}
|
||||
/>
|
||||
),
|
||||
|
||||
Reference in New Issue
Block a user