Lint all files in the repo (#9131)

Co-authored-by: openhands <openhands@all-hands.dev>
Co-authored-by: Engel Nyst <enyst@users.noreply.github.com>

openhands/server/config/server_config.py

@@ -53,7 +53,7 @@ def load_server_config() -> ServerConfig:
     logger.info(f'Using config class {config_cls}')
 
     server_config_cls = get_impl(ServerConfig, config_cls)
-    server_config : ServerConfig = server_config_cls()
+    server_config: ServerConfig = server_config_cls()
     server_config.verify_config()
 
     return server_config

openhands/server/conversation_manager/standalone_conversation_manager.py

@@ -15,7 +15,7 @@ from openhands.events.stream import EventStreamSubscriber, session_exists
 from openhands.server.config.server_config import ServerConfig
 from openhands.server.data_models.agent_loop_info import AgentLoopInfo
 from openhands.server.monitoring import MonitoringListener
-from openhands.server.session.agent_session import AgentSession, WAIT_TIME_BEFORE_CLOSE
+from openhands.server.session.agent_session import WAIT_TIME_BEFORE_CLOSE, AgentSession
 from openhands.server.session.conversation import ServerConversation
 from openhands.server.session.session import ROOM_KEY, Session
 from openhands.storage.conversation.conversation_store import ConversationStore
@@ -508,7 +508,9 @@ class StandaloneConversationManager(ConversationManager):
             session_api_key=None,
             event_store=session.agent_session.event_stream,
             status=_get_status_from_session(session),
-            runtime_status=getattr(session.agent_session.runtime, 'runtime_status', None),
+            runtime_status=getattr(
+                session.agent_session.runtime, 'runtime_status', None
+            ),
         )
 
     def _get_conversation_url(self, conversation_id: str):

openhands/server/data_models/conversation_info.py

@@ -1,7 +1,6 @@
 from dataclasses import dataclass, field
 from datetime import datetime, timezone
 
-from openhands.core.schema.agent import AgentState
 from openhands.integrations.service_types import ProviderType
 from openhands.runtime.runtime_status import RuntimeStatus
 from openhands.storage.data_models.conversation_metadata import ConversationTrigger

openhands/server/routes/conversation.py

@@ -5,13 +5,13 @@ from pydantic import BaseModel
 from openhands.core.logger import openhands_logger as logger
 from openhands.events.event_filter import EventFilter
 from openhands.events.serialization.event import event_to_dict
+from openhands.memory.memory import Memory
+from openhands.microagent.types import InputMetadata
 from openhands.runtime.base import Runtime
 from openhands.server.dependencies import get_dependencies
 from openhands.server.session.conversation import ServerConversation
 from openhands.server.shared import conversation_manager
 from openhands.server.utils import get_conversation
-from openhands.microagent.types import InputMetadata
-from openhands.memory.memory import Memory
 
 app = APIRouter(
     prefix='/api/conversations/{conversation_id}', dependencies=get_dependencies()
@@ -216,7 +216,11 @@ async def get_microagents(
                     content=agent.content,
                     triggers=[],
                     inputs=agent.metadata.inputs,
-                    tools=[server.name for server in agent.metadata.mcp_tools.stdio_servers] if agent.metadata.mcp_tools else [],
+                    tools=[
+                        server.name for server in agent.metadata.mcp_tools.stdio_servers
+                    ]
+                    if agent.metadata.mcp_tools
+                    else [],
                 )
             )
 
@@ -229,7 +233,11 @@ async def get_microagents(
                     content=agent.content,
                     triggers=agent.triggers,
                     inputs=agent.metadata.inputs,
-                    tools=[server.name for server in agent.metadata.mcp_tools.stdio_servers] if agent.metadata.mcp_tools else [],
+                    tools=[
+                        server.name for server in agent.metadata.mcp_tools.stdio_servers
+                    ]
+                    if agent.metadata.mcp_tools
+                    else [],
                 )
             )
 

openhands/server/routes/feedback.py

@@ -6,15 +6,19 @@ from openhands.events.async_event_store_wrapper import AsyncEventStoreWrapper
 from openhands.events.serialization import event_to_dict
 from openhands.server.data_models.feedback import FeedbackDataModel, store_feedback
 from openhands.server.dependencies import get_dependencies
+from openhands.server.session.conversation import ServerConversation
 from openhands.server.utils import get_conversation
 from openhands.utils.async_utils import call_sync_from_async
-from openhands.server.session.conversation import ServerConversation
 
-app = APIRouter(prefix='/api/conversations/{conversation_id}', dependencies=get_dependencies())
+app = APIRouter(
+    prefix='/api/conversations/{conversation_id}', dependencies=get_dependencies()
+)
 
 
 @app.post('/submit-feedback')
-async def submit_feedback(request: Request, conversation: ServerConversation = Depends(get_conversation)) -> JSONResponse:
+async def submit_feedback(
+    request: Request, conversation: ServerConversation = Depends(get_conversation)
+) -> JSONResponse:
     """Submit user feedback.
 
     This function stores the provided feedback data.
@@ -37,9 +41,7 @@ async def submit_feedback(request: Request, conversation: ServerConversation = D
     # Assuming the storage service is already configured in the backend
     # and there is a function to handle the storage.
     body = await request.json()
-    async_store = AsyncEventStoreWrapper(
-        conversation.event_stream, filter_hidden=True
-    )
+    async_store = AsyncEventStoreWrapper(conversation.event_stream, filter_hidden=True)
     trajectory = []
     async for event in async_store:
         trajectory.append(event_to_dict(event))

openhands/server/routes/files.py

@@ -5,7 +5,6 @@ from fastapi import (
     APIRouter,
     Depends,
     HTTPException,
-    Request,
     status,
 )
 from fastapi.responses import FileResponse, JSONResponse
@@ -27,17 +26,15 @@ from openhands.server.dependencies import get_dependencies
 from openhands.server.file_config import (
     FILES_TO_IGNORE,
 )
-from openhands.server.shared import (
-    ConversationStoreImpl,
-    config,
-)
+from openhands.server.session.conversation import ServerConversation
 from openhands.server.user_auth import get_user_id
 from openhands.server.utils import get_conversation, get_conversation_store
 from openhands.storage.conversation.conversation_store import ConversationStore
 from openhands.utils.async_utils import call_sync_from_async
-from openhands.server.session.conversation import ServerConversation
 
-app = APIRouter(prefix='/api/conversations/{conversation_id}', dependencies=get_dependencies())
+app = APIRouter(
+    prefix='/api/conversations/{conversation_id}', dependencies=get_dependencies()
+)
 
 
 @app.get(
@@ -50,7 +47,7 @@ app = APIRouter(prefix='/api/conversations/{conversation_id}', dependencies=get_
 )
 async def list_files(
     conversation: ServerConversation = Depends(get_conversation),
-    path: str | None = None
+    path: str | None = None,
 ) -> list[str] | JSONResponse:
     """List files in the specified path.
 
@@ -132,7 +129,9 @@ async def list_files(
         415: {'description': 'Unsupported media type', 'model': dict},
     },
 )
-async def select_file(file: str, conversation: ServerConversation = Depends(get_conversation)) -> FileResponse | JSONResponse:
+async def select_file(
+    file: str, conversation: ServerConversation = Depends(get_conversation)
+) -> FileResponse | JSONResponse:
     """Retrieve the content of a specified file.
 
     To select a file:
@@ -196,7 +195,9 @@ async def select_file(file: str, conversation: ServerConversation = Depends(get_
         500: {'description': 'Error zipping workspace', 'model': dict},
     },
 )
-def zip_current_workspace(conversation: ServerConversation = Depends(get_conversation)) -> FileResponse | JSONResponse:
+def zip_current_workspace(
+    conversation: ServerConversation = Depends(get_conversation),
+) -> FileResponse | JSONResponse:
     try:
         logger.debug('Zipping workspace')
         runtime: Runtime = conversation.runtime

openhands/server/routes/manage_conversations.py

@@ -1,6 +1,6 @@
 import itertools
-import re
 import os
+import re
 import uuid
 from datetime import datetime, timezone
 
@@ -9,19 +9,18 @@ from fastapi.responses import JSONResponse
 from jinja2 import Environment, FileSystemLoader
 from pydantic import BaseModel, Field
 
-from openhands.events.event_filter import EventFilter
-from openhands.events.stream import EventStream
+from openhands.core.config.llm_config import LLMConfig
+from openhands.core.logger import openhands_logger as logger
 from openhands.events.action import (
     ChangeAgentStateAction,
     NullAction,
 )
+from openhands.events.event_filter import EventFilter
 from openhands.events.observation import (
-    NullObservation,
     AgentStateChangedObservation,
+    NullObservation,
 )
-
-from openhands.core.config.llm_config import LLMConfig
-from openhands.core.logger import openhands_logger as logger
+from openhands.events.stream import EventStream
 from openhands.integrations.provider import (
     PROVIDER_TOKEN_TYPE,
     ProviderHandler,
@@ -38,10 +37,9 @@ from openhands.server.data_models.conversation_info import ConversationInfo
 from openhands.server.data_models.conversation_info_result_set import (
     ConversationInfoResultSet,
 )
-from openhands.server.services.conversation_service import create_new_conversation
-from openhands.server.session.conversation import ServerConversation
 from openhands.server.dependencies import get_dependencies
 from openhands.server.services.conversation_service import create_new_conversation
+from openhands.server.session.conversation import ServerConversation
 from openhands.server.shared import (
     ConversationStoreImpl,
     config,
@@ -53,11 +51,12 @@ from openhands.server.user_auth import (
     get_provider_tokens,
     get_user_id,
     get_user_secrets,
-    get_user_settings_store,
     get_user_settings,
+    get_user_settings_store,
 )
 from openhands.server.user_auth.user_auth import AuthType
-from openhands.server.utils import get_conversation_store, get_conversation as get_conversation_object
+from openhands.server.utils import get_conversation as get_conversation_object
+from openhands.server.utils import get_conversation_store
 from openhands.storage.conversation.conversation_store import ConversationStore
 from openhands.storage.data_models.conversation_metadata import (
     ConversationMetadata,
@@ -295,7 +294,7 @@ async def delete_conversation(
 async def get_prompt(
     event_id: int,
     user_settings: SettingsStore = Depends(get_user_settings_store),
-    conversation: ServerConversation | None = Depends(get_conversation_object)
+    conversation: ServerConversation | None = Depends(get_conversation_object),
 ):
     if conversation is None:
         return JSONResponse(
@@ -409,7 +408,6 @@ async def start_conversation(
     logger.info(f'Starting conversation: {conversation_id}')
 
     try:
-
         # Check that the conversation exists
         try:
             await conversation_store.get_metadata(conversation_id)
@@ -463,10 +461,17 @@ async def stop_conversation(
 
     try:
         # Check if the conversation is running
-        agent_loop_info = await conversation_manager.get_agent_loop_info(user_id=user_id, filter_to_sids={conversation_id})
-        conversation_status = agent_loop_info[0].status if agent_loop_info else ConversationStatus.STOPPED
+        agent_loop_info = await conversation_manager.get_agent_loop_info(
+            user_id=user_id, filter_to_sids={conversation_id}
+        )
+        conversation_status = (
+            agent_loop_info[0].status if agent_loop_info else ConversationStatus.STOPPED
+        )
 
-        if conversation_status not in (ConversationStatus.STARTING, ConversationStatus.RUNNING):
+        if conversation_status not in (
+            ConversationStatus.STARTING,
+            ConversationStatus.RUNNING,
+        ):
             return ConversationResponse(
                 status='ok',
                 conversation_id=conversation_id,
@@ -505,9 +510,13 @@ def _get_contextual_events(event_stream: EventStream, event_id: int) -> str:
 
     agent_event_filter = EventFilter(
         exclude_hidden=True,
-        exclude_types=(NullAction, NullObservation, ChangeAgentStateAction, AgentStateChangedObservation
+        exclude_types=(
+            NullAction,
+            NullObservation,
+            ChangeAgentStateAction,
+            AgentStateChangedObservation,
         ),
-    ) # the types of events that can be in an agent's history
+    )  # the types of events that can be in an agent's history
 
     # from event_id - context_size to event_id..
     context_before = event_stream.search_events(

openhands/server/routes/mcp.py

@@ -87,7 +87,7 @@ async def create_pr(
     target_branch: Annotated[str, Field(description='Target branch on repo')],
     title: Annotated[str, Field(description='PR Title')],
     body: Annotated[str | None, Field(description='PR body')],
-    draft: Annotated[bool, Field(description='Whether PR opened is a draft')] = True
+    draft: Annotated[bool, Field(description='Whether PR opened is a draft')] = True,
 ) -> str:
     """Open a PR in GitHub"""
 
@@ -127,7 +127,7 @@ async def create_pr(
             target_branch=target_branch,
             title=title,
             body=body,
-            draft=draft
+            draft=draft,
         )
 
         if conversation_id:
@@ -148,7 +148,12 @@ async def create_mr(
     ],
     source_branch: Annotated[str, Field(description='Source branch on repo')],
     target_branch: Annotated[str, Field(description='Target branch on repo')],
-    title: Annotated[str, Field(description='MR Title. Start title with `DRAFT:` or `WIP:` if applicable.')],
+    title: Annotated[
+        str,
+        Field(
+            description='MR Title. Start title with `DRAFT:` or `WIP:` if applicable.'
+        ),
+    ],
     description: Annotated[str | None, Field(description='MR description')],
 ) -> str:
     """Open a MR in GitLab"""

openhands/server/routes/security.py

@@ -8,14 +8,18 @@ from fastapi import (
 )
 
 from openhands.server.dependencies import get_dependencies
-from openhands.server.utils import get_conversation
 from openhands.server.session.conversation import ServerConversation
+from openhands.server.utils import get_conversation
 
-app = APIRouter(prefix='/api/conversations/{conversation_id}', dependencies=get_dependencies())
+app = APIRouter(
+    prefix='/api/conversations/{conversation_id}', dependencies=get_dependencies()
+)
 
 
 @app.route('/security/{path:path}', methods=['GET', 'POST', 'PUT', 'DELETE'])
-async def security_api(request: Request, conversation: ServerConversation = Depends(get_conversation)) -> Response:
+async def security_api(
+    request: Request, conversation: ServerConversation = Depends(get_conversation)
+) -> Response:
     """Catch-all route for security analyzer API requests.
 
     Each request is handled directly to the security analyzer.
@@ -35,6 +39,4 @@ async def security_api(request: Request, conversation: ServerConversation = Depe
             detail='Security analyzer not initialized',
         )
 
-    return await conversation.security_analyzer.handle_api_request(
-        request
-    )
+    return await conversation.security_analyzer.handle_api_request(request)

openhands/server/routes/trajectory.py

@@ -1,18 +1,22 @@
-from fastapi import APIRouter, Depends, Request, status
+from fastapi import APIRouter, Depends, status
 from fastapi.responses import JSONResponse
 
 from openhands.core.logger import openhands_logger as logger
 from openhands.events.async_event_store_wrapper import AsyncEventStoreWrapper
 from openhands.events.serialization import event_to_trajectory
 from openhands.server.dependencies import get_dependencies
-from openhands.server.utils import get_conversation
 from openhands.server.session.conversation import ServerConversation
+from openhands.server.utils import get_conversation
 
-app = APIRouter(prefix='/api/conversations/{conversation_id}', dependencies=get_dependencies())
+app = APIRouter(
+    prefix='/api/conversations/{conversation_id}', dependencies=get_dependencies()
+)
 
 
 @app.get('/trajectory')
-async def get_trajectory(conversation: ServerConversation = Depends(get_conversation)) -> JSONResponse:
+async def get_trajectory(
+    conversation: ServerConversation = Depends(get_conversation),
+) -> JSONResponse:
     """Get trajectory.
 
     This function retrieves the current trajectory and returns it.

openhands/server/services/conversation_service.py

@@ -1,4 +1,3 @@
-import os
 import uuid
 from typing import Any
 
@@ -80,7 +79,6 @@ async def create_new_conversation(
     session_init_args['conversation_instructions'] = conversation_instructions
     conversation_init_data = ConversationInitData(**session_init_args)
 
-
     logger.info('Loading conversation store')
     conversation_store = await ConversationStoreImpl.get_instance(config, user_id)
     logger.info('ServerConversation store loaded')
@@ -90,13 +88,14 @@ async def create_new_conversation(
         conversation_id = uuid.uuid4().hex
 
     if not await conversation_store.exists(conversation_id):
-
         logger.info(
             f'New conversation ID: {conversation_id}',
             extra={'user_id': user_id, 'session_id': conversation_id},
         )
 
-        conversation_init_data = ExperimentManagerImpl.run_conversation_variant_test(user_id, conversation_id, conversation_init_data)
+        conversation_init_data = ExperimentManagerImpl.run_conversation_variant_test(
+            user_id, conversation_id, conversation_init_data
+        )
         conversation_title = get_default_conversation_title(conversation_id)
 
         logger.info(f'Saving metadata for conversation {conversation_id}')

openhands/server/session/agent_session.py

@@ -197,23 +197,21 @@ class AgentSession:
         finally:
             self._starting = False
             success = finished and runtime_connected
-            duration = (time.time() - started_at)
+            duration = time.time() - started_at
 
             log_metadata = {
                 'signal': 'agent_session_start',
                 'success': success,
                 'duration': duration,
-                'restored_state': restored_state
+                'restored_state': restored_state,
             }
             if success:
                 self.logger.info(
-                    f'Agent session start succeeded in {duration}s',
-                    extra=log_metadata
+                    f'Agent session start succeeded in {duration}s', extra=log_metadata
                 )
             else:
                 self.logger.error(
-                    f'Agent session start failed in {duration}s',
-                    extra=log_metadata
+                    f'Agent session start failed in {duration}s', extra=log_metadata
                 )
 
     async def close(self) -> None: