Enforce linter in tests folder (#2557)

This commit is contained in:
Boxuan Li 2024-06-20 21:50:34 -07:00 committed by GitHub
parent f3ba2f02d5
commit 01fa52d062
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
8 changed files with 18 additions and 37 deletions

View File

@ -47,4 +47,4 @@ jobs:
- name: Install pre-commit
run: pip install pre-commit==3.7.0
- name: Run pre-commit hooks
run: pre-commit run --files opendevin/**/* agenthub/**/* evaluation/**/* --show-diff-on-failure --config ./dev_config/python/.pre-commit-config.yaml
run: pre-commit run --files opendevin/**/* agenthub/**/* evaluation/**/* tests/**/* --show-diff-on-failure --config ./dev_config/python/.pre-commit-config.yaml

View File

@ -123,4 +123,4 @@ Here is an example with chain of thought of a valid action when clicking on a bu
"
In order to accomplish my goal I need to click on the button with bid 12
```click("12")```
"
"

View File

@ -127,4 +127,4 @@ Here is an example with chain of thought of a valid action when clicking on a bu
"
In order to accomplish my goal I need to click on the button with bid 12
```click("12")```
"
"

View File

@ -129,4 +129,4 @@ Here is an example with chain of thought of a valid action when clicking on a bu
"
In order to accomplish my goal I need to click on the button with bid 12
```click("12")```
"
"

View File

@ -2,4 +2,3 @@ Let's start by opening the `bad.txt` file to identify and fix the typos.
<execute_ipython>
open_file("bad.txt")

View File

@ -6,4 +6,3 @@ Let's correct the typos in the `bad.txt` file.
I will make these changes now.
<execute_ipython>
edit_file("bad.txt", start=1, end=4, content="This is a stupid typo.\nReally?\nNo more typos!\nEnjoy!")

View File

@ -2,4 +2,3 @@ The shell script `hello.sh` has been created and made executable. Let's run it t
<execute_bash>
./hello.sh

View File

@ -294,40 +294,27 @@ def test_sandbox_jupyter_plugin(temp_dir):
)
box.close()
def _test_sandbox_jupyter_agentskills_fileop_pwd_impl(box):
box.init_plugins([AgentSkillsRequirement, JupyterRequirement])
exit_code, output = box.execute('mkdir test')
print(output)
assert exit_code == 0, (
'The exit code should be 0 for ' + box.__class__.__name__
)
assert exit_code == 0, 'The exit code should be 0 for ' + box.__class__.__name__
exit_code, output = box.execute(
'echo "create_file(\'a.txt\')" | execute_cli'
)
exit_code, output = box.execute('echo "create_file(\'a.txt\')" | execute_cli')
print(output)
assert exit_code == 0, (
'The exit code should be 0 for ' + box.__class__.__name__
)
assert exit_code == 0, 'The exit code should be 0 for ' + box.__class__.__name__
assert output.strip().split('\r\n') == (
'[File: /workspace/a.txt (1 lines total)]\r\n'
'1|\r\n'
'[File a.txt created.]'
'[File: /workspace/a.txt (1 lines total)]\r\n' '1|\r\n' '[File a.txt created.]'
).strip().split('\r\n')
exit_code, output = box.execute('cd test')
print(output)
assert exit_code == 0, (
'The exit code should be 0 for ' + box.__class__.__name__
)
assert exit_code == 0, 'The exit code should be 0 for ' + box.__class__.__name__
exit_code, output = box.execute(
'echo "create_file(\'a.txt\')" | execute_cli'
)
exit_code, output = box.execute('echo "create_file(\'a.txt\')" | execute_cli')
print(output)
assert exit_code == 0, (
'The exit code should be 0 for ' + box.__class__.__name__
)
assert exit_code == 0, 'The exit code should be 0 for ' + box.__class__.__name__
assert output.strip().split('\r\n') == (
'[File: /workspace/test/a.txt (1 lines total)]\r\n'
'1|\r\n'
@ -335,9 +322,7 @@ def _test_sandbox_jupyter_agentskills_fileop_pwd_impl(box):
).strip().split('\r\n')
exit_code, output = box.execute('rm -rf /workspace/*')
assert exit_code == 0, (
'The exit code should be 0 for ' + box.__class__.__name__
)
assert exit_code == 0, 'The exit code should be 0 for ' + box.__class__.__name__
box.close()
@ -352,18 +337,17 @@ def test_sandbox_jupyter_agentskills_fileop_pwd(temp_dir):
_test_sandbox_jupyter_agentskills_fileop_pwd_impl(box)
@pytest.mark.skipif(os.getenv('TEST_IN_CI') != 'true',
@pytest.mark.skipif(
os.getenv('TEST_IN_CI') != 'true',
reason='The unittest need to download image, so only run on CI',
)
def test_agnostic_sandbox_jupyter_agentskills_fileop_pwd(temp_dir):
for base_sandbox_image in ['ubuntu:22.04', 'debian:11']:
# get a temporary directory
with patch.object(config, 'workspace_base', new=temp_dir), patch.object(
config, 'workspace_mount_path', new=temp_dir
config, 'workspace_mount_path', new=temp_dir
), patch.object(config, 'run_as_devin', new='true'), patch.object(
config, 'sandbox_type', new='ssh'
), patch.object(
config, 'sandbox_container_image', new=base_sandbox_image
):
), patch.object(config, 'sandbox_container_image', new=base_sandbox_image):
for box in [DockerSSHBox()]:
_test_sandbox_jupyter_agentskills_fileop_pwd_impl(box)
_test_sandbox_jupyter_agentskills_fileop_pwd_impl(box)